-
Notifications
You must be signed in to change notification settings - Fork 624
Refetch token if attempt was invalidated #1628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (060ff43d) is created by Prow via merging commits: 3da23a6 d041342. |
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (060ff43d) is created by Prow via merging commits: 3da23a6 d041342. |
@schmidt-sebastian: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
throw new FirebaseFirestoreException( | ||
"getToken aborted due to token change", Code.ABORTED); | ||
Logger.debug(LOG_TAG, "getToken aborted due to token change"); | ||
return getToken(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General observation: it seems a little unfortunate that getToken
and getResult().getToken()
look so similar while having a very different effect. In general, I'd expect a get
-prefixed function to be a simple getter, so it might be better to rename getToken
to something like fetchToken
to better convey its semantics. Of course, this is absolutely out of scope for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack :)
Port of firebase/firebase-js-sdk#3184