Skip to content

Refetch token if attempt was invalidated #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@googlebot googlebot added the cla: yes Override cla label Jun 8, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 8, 2020

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (3da23a6) Head (060ff43d) Diff
    apk (aggressive) 82.5 kB 82.5 kB -17 B (-0.0%)
    apk (debug) 770 kB 770 kB -3 B (-0.0%)
  • firebase-components

    Type Base (3da23a6) Head (060ff43d) Diff
    apk (aggressive) 10.9 kB 11.0 kB +11 B (+0.1%)
    apk (debug) 35.8 kB 35.9 kB +26 B (+0.1%)
  • firebase-database-collection

    Type Base (3da23a6) Head (060ff43d) Diff
    apk (aggressive) 314 kB 314 kB +2 B (+0.0%)
    apk (debug) 1.07 MB 1.07 MB +100 B (+0.0%)
  • firebase-firestore

    Type Base (3da23a6) Head (060ff43d) Diff
    aar 1.07 MB 1.07 MB +103 B (+0.0%)
    apk (debug) 3.74 MB 3.74 MB +22 B (+0.0%)
    apk (release) 3.13 MB 3.13 MB +167 B (+0.0%)
  • protolite-well-known-types

    Type Base (3da23a6) Head (060ff43d) Diff
    apk (debug) 643 kB 643 kB -16 B (-0.0%)

Test Logs

Notes

Head commit (060ff43d) is created by Prow via merging commits: 3da23a6 d041342.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 8, 2020

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 43.11% (3da23a6) to 43.11% (060ff43d) by -0.00%.

    Filename Base (3da23a6) Head (060ff43d) Diff

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (060ff43d) is created by Prow via merging commits: 3da23a6 d041342.

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests d041342 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

throw new FirebaseFirestoreException(
"getToken aborted due to token change", Code.ABORTED);
Logger.debug(LOG_TAG, "getToken aborted due to token change");
return getToken();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General observation: it seems a little unfortunate that getToken and getResult().getToken() look so similar while having a very different effect. In general, I'd expect a get-prefixed function to be a simple getter, so it might be better to rename getToken to something like fetchToken to better convey its semantics. Of course, this is absolutely out of scope for this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack :)

@schmidt-sebastian schmidt-sebastian merged commit 58e83e6 into master Jun 8, 2020
@firebase firebase locked and limited conversation to collaborators Jul 9, 2020
@kaibolay kaibolay deleted the mrschmidt/token branch September 14, 2022 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants