Skip to content

Temporarily change back to 3.4.2 #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2020
Merged

Temporarily change back to 3.4.2 #1689

merged 1 commit into from
Jun 19, 2020

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jun 19, 2020

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jun 19, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 51.19% (5e5111b) to 51.20% (db2e3e5a) by +0.01%.

    Filename Base (5e5111b) Head (db2e3e5a) Diff
    DoubleNode.java 88.89% 100.00% +11.11%
    ViewProcessor.java 92.35% 92.05% -0.31%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (db2e3e5a) is created by Prow via merging commits: 5e5111b 5a05faf.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 35.0 kB 35.4 kB +357 B (+1.0%)
    apk (aggressive) ? 85.5 kB ? (?)
    apk (debug) ? 895 kB ? (?)
    apk (release) ? 738 kB ? (?)

  • firebase-common

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 37.6 kB 38.1 kB +422 B (+1.1%)
    apk (aggressive) ? 82.7 kB ? (?)
    apk (debug) ? 772 kB ? (?)
    apk (release) ? 637 kB ? (?)

  • firebase-common-ktx

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 5.66 kB 5.97 kB +310 B (+5.5%)
    apk (aggressive) ? 272 kB ? (?)
    apk (debug) ? 1.56 MB ? (?)
    apk (release) ? 1.27 MB ? (?)

  • firebase-components

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 34.4 kB 34.5 kB +98 B (+0.3%)
    apk (aggressive) ? 11.0 kB ? (?)
    apk (debug) ? 35.9 kB ? (?)
    apk (release) ? 25.4 kB ? (?)

  • firebase-config

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 214 kB 215 kB +507 B (+0.2%)
    apk (aggressive) ? 130 kB ? (?)
    apk (debug) ? 1.05 MB ? (?)
    apk (release) ? 871 kB ? (?)

  • firebase-config-ktx

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 5.41 kB 5.83 kB +418 B (+7.7%)
    apk (aggressive) ? 319 kB ? (?)
    apk (debug) ? 1.84 MB ? (?)
    apk (release) ? 1.50 MB ? (?)

  • firebase-crashlytics

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 409 kB 410 kB +723 B (+0.2%)
    apk (aggressive) ? 599 kB ? (?)
    apk (debug) ? 1.60 MB ? (?)
    apk (release) ? 1.36 MB ? (?)

  • firebase-crashlytics-ktx

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 6.65 kB 7.15 kB +499 B (+7.5%)
    apk (aggressive) ? 789 kB ? (?)
    apk (debug) ? 2.39 MB ? (?)
    apk (release) ? 2.00 MB ? (?)

  • firebase-crashlytics-ndk

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 598 kB 599 kB +543 B (+0.1%)
    apk (aggressive) ? 1.19 MB ? (?)
    apk (debug) ? 2.23 MB ? (?)
    apk (release) ? 1.95 MB ? (?)

  • firebase-database

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 482 kB 482 kB +604 B (+0.1%)
    apk (aggressive) ? 326 kB ? (?)
    apk (debug) ? 1.29 MB ? (?)
    apk (release) ? 1.09 MB ? (?)

  • firebase-database-collection

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 33.6 kB 34.2 kB +576 B (+1.7%)
    apk (aggressive) ? 314 kB ? (?)
    apk (debug) ? 1.07 MB ? (?)
    apk (release) ? 913 kB ? (?)

  • firebase-database-ktx

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 6.90 kB 7.40 kB +501 B (+7.3%)
    apk (aggressive) ? 515 kB ? (?)
    apk (debug) ? 2.08 MB ? (?)
    apk (release) ? 1.73 MB ? (?)

  • firebase-datatransport

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 4.73 kB 5.04 kB +309 B (+6.5%)
    apk (aggressive) ? 117 kB ? (?)
    apk (debug) ? 848 kB ? (?)
    apk (release) ? 700 kB ? (?)

  • firebase-decoders-json

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 7.52 kB 7.52 kB -4 B (-0.1%)
    apk (aggressive) ? 11.0 kB ? (?)
    apk (debug) ? 23.7 kB ? (?)
    apk (release) ? 15.5 kB ? (?)

  • firebase-dynamic-links

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 50.6 kB 51.2 kB +592 B (+1.2%)
    apk (aggressive) ? 327 kB ? (?)
    apk (debug) ? 1.10 MB ? (?)
    apk (release) ? 942 kB ? (?)

  • firebase-dynamic-links-ktx

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 7.39 kB 7.88 kB +494 B (+6.7%)
    apk (aggressive) ? 517 kB ? (?)
    apk (debug) ? 1.89 MB ? (?)
    apk (release) ? 1.58 MB ? (?)

  • firebase-encoders-json

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 18.1 kB 18.2 kB +54 B (+0.3%)
    apk (aggressive) ? 11.0 kB ? (?)
    apk (debug) ? 28.6 kB ? (?)
    apk (release) ? 19.9 kB ? (?)

  • firebase-encoders-reflective

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 7.65 kB 7.65 kB +4 B (+0.1%)
    apk (aggressive) ? 11.0 kB ? (?)
    apk (debug) ? 31.1 kB ? (?)
    apk (release) ? 22.0 kB ? (?)

  • firebase-firestore

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 1.07 MB 1.07 MB +252 B (+0.0%)
    apk (aggressive) ? 443 kB ? (?)
    apk (debug) ? 3.74 MB ? (?)
    apk (release) ? 3.13 MB ? (?)

  • firebase-firestore-ktx

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 6.59 kB 7.08 kB +491 B (+7.5%)
    apk (aggressive) ? 633 kB ? (?)
    apk (debug) ? 4.53 MB ? (?)
    apk (release) ? 3.77 MB ? (?)

  • firebase-functions

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 25.3 kB 25.9 kB +552 B (+2.2%)
    apk (aggressive) ? 394 kB ? (?)
    apk (debug) ? 1.37 MB ? (?)
    apk (release) ? 1.17 MB ? (?)

  • firebase-functions-ktx

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 5.34 kB 5.84 kB +502 B (+9.4%)
    apk (aggressive) ? 583 kB ? (?)
    apk (debug) ? 2.16 MB ? (?)
    apk (release) ? 1.80 MB ? (?)

  • firebase-inappmessaging

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 473 kB 474 kB +572 B (+0.1%)
    apk (aggressive) ? 610 kB ? (?)
    apk (debug) ? 4.02 MB ? (?)
    apk (release) ? 3.29 MB ? (?)

  • firebase-inappmessaging-display

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 163 kB 167 kB +4.91 kB (+3.0%)

  • firebase-inappmessaging-display-ktx

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 17.4 kB 22.2 kB +4.77 kB (+27.4%)

  • firebase-inappmessaging-ktx

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 4.87 kB 5.29 kB +422 B (+8.7%)
    apk (aggressive) ? 800 kB ? (?)
    apk (debug) ? 4.81 MB ? (?)
    apk (release) ? 3.92 MB ? (?)

  • firebase-installations

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 57.7 kB 58.1 kB +399 B (+0.7%)
    apk (aggressive) ? 84.4 kB ? (?)
    apk (debug) ? 796 kB ? (?)
    apk (release) ? 657 kB ? (?)

  • firebase-installations-interop

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 7.18 kB 7.51 kB +327 B (+4.6%)
    apk (aggressive) ? 61.7 kB ? (?)
    apk (debug) ? 744 kB ? (?)
    apk (release) ? 616 kB ? (?)

  • firebase-segmentation

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 30.8 kB 34.8 kB +4.01 kB (+13.0%)
    apk (aggressive) ? 802 kB ? (?)
    apk (debug) ? 1.61 MB ? (?)
    apk (release) ? 1.38 MB ? (?)

  • firebase-storage

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 119 kB 119 kB +613 B (+0.5%)
    apk (aggressive) ? 326 kB ? (?)
    apk (debug) ? 1.13 MB ? (?)
    apk (release) ? 967 kB ? (?)

  • firebase-storage-ktx

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 5.66 kB 6.14 kB +488 B (+8.6%)
    apk (aggressive) ? 515 kB ? (?)
    apk (debug) ? 1.92 MB ? (?)
    apk (release) ? 1.60 MB ? (?)

  • protolite-well-known-types

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 1.20 MB 1.20 MB +189 B (+0.0%)
    apk (aggressive) ? 122 kB ? (?)
    apk (debug) ? 643 kB ? (?)
    apk (release) ? 561 kB ? (?)

  • transport-api

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 6.58 kB 6.59 kB +6 B (+0.1%)
    apk (aggressive) ? 11.0 kB ? (?)
    apk (debug) ? 23.0 kB ? (?)
    apk (release) ? 15.1 kB ? (?)

  • transport-backend-cct

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 43.3 kB 39.0 kB -4.37 kB (-10.1%)
    apk (aggressive) ? 47.9 kB ? (?)
    apk (debug) ? 102 kB ? (?)
    apk (release) ? 82.4 kB ? (?)

  • transport-runtime

    Type Base (5e5111b) Head (db2e3e5a) Diff
    aar 127 kB 127 kB +177 B (+0.1%)
    apk (aggressive) ? 35.6 kB ? (?)
    apk (debug) ? 80.6 kB ? (?)
    apk (release) ? 62.9 kB ? (?)

Test Logs

Notes

Head commit (db2e3e5a) is created by Prow via merging commits: 5e5111b 5a05faf.

@rlazo rlazo marked this pull request as ready for review June 19, 2020 16:27
@rlazo rlazo requested a review from VinayGuthal June 19, 2020 16:44
@rlazo rlazo merged commit 516c06b into master Jun 19, 2020
@rlazo rlazo deleted the rl.back branch June 19, 2020 17:09
@firebase firebase locked and limited conversation to collaborators Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@ashwinraghav ashwinraghav Awaiting requested review from ashwinraghav

@davidmotson davidmotson Awaiting requested review from davidmotson

@VinayGuthal VinayGuthal Awaiting requested review from VinayGuthal

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rlazo @google-oss-bot @vkryachko @googlebot