Skip to content

Migrate metalava download to gradle's resolution process. #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2020

Conversation

vkryachko
Copy link
Member

Additionally rewrite GenerateStubsTask to Kotlin.

Additionally rewrite `GenerateStubsTask` to Kotlin.
@vkryachko vkryachko requested a review from VinayGuthal July 20, 2020 15:23
@googlebot googlebot added the cla: yes Override cla label Jul 20, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 20, 2020

Coverage Report

Affected SDKs

  • firebase-storage

    SDK overall coverage changed from ? (1f78af9) to 85.48% (007d0abd) by ?.

    Click to show coverage changes in 45 files.
    Filename Base (1f78af9) Head (007d0abd) Diff
    ActivityLifecycleListener.java ? 74.14% ?
    AdaptiveStreamBuffer.java ? 84.62% ?
    CancelException.java ? 100.00% ?
    CancellableTask.java ? 100.00% ?
    ControllableTask.java ? 100.00% ?
    DeleteNetworkRequest.java ? 100.00% ?
    DeleteStorageTask.java ? 100.00% ?
    ExponentialBackoffSender.java ? 86.05% ?
    FileDownloadTask.java ? 77.60% ?
    FirebaseStorage.java ? 84.34% ?
    FirebaseStorageComponent.java ? 100.00% ?
    GetDownloadUrlTask.java ? 96.67% ?
    GetMetadataNetworkRequest.java ? 100.00% ?
    GetMetadataTask.java ? 84.62% ?
    GetNetworkRequest.java ? 100.00% ?
    HttpURLConnectionFactory.java ? 0.00% ?
    HttpURLConnectionFactoryImpl.java ? 50.00% ?
    ListNetworkRequest.java ? 100.00% ?
    ListResult.java ? 100.00% ?
    ListTask.java ? 85.19% ?
    NetworkRequest.java ? 89.29% ?
    OnPausedListener.java ? 0.00% ?
    OnProgressListener.java ? 0.00% ?
    ResumableNetworkRequest.java ? 100.00% ?
    ResumableUploadByteRequest.java ? 90.91% ?
    ResumableUploadCancelRequest.java ? 100.00% ?
    ResumableUploadQueryRequest.java ? 100.00% ?
    ResumableUploadStartRequest.java ? 95.00% ?
    Slashes.java ? 82.35% ?
    Sleeper.java ? 0.00% ?
    SleeperImpl.java ? 33.33% ?
    SmartHandler.java ? 87.50% ?
    StorageException.java ? 65.45% ?
    StorageMetadata.java ? 86.34% ?
    StorageReference.java ? 89.88% ?
    StorageRegistrar.java ? 100.00% ?
    StorageTask.java ? 84.29% ?
    StorageTaskManager.java ? 100.00% ?
    StorageTaskScheduler.java ? 100.00% ?
    StreamDownloadTask.java ? 88.89% ?
    TaskListenerImpl.java ? 100.00% ?
    UpdateMetadataNetworkRequest.java ? 100.00% ?
    UpdateMetadataTask.java ? 80.00% ?
    UploadTask.java ? 80.22% ?
    Util.java ? 65.57% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (007d0abd) is created by Prow via merging commits: 1f78af9 ec2b145.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 20, 2020

Binary Size Report

Affected SDKs

  • firebase-installations

    Type Base (1f78af9) Head (007d0abd) Diff
    aar 59.2 kB 59.2 kB -14 B (-0.0%)

Test Logs

Notes

Head commit (007d0abd) is created by Prow via merging commits: 1f78af9 ec2b145.

@vkryachko
Copy link
Member Author

/retest

@vkryachko vkryachko merged commit ed8977b into master Aug 13, 2020
@google-oss-bot
Copy link
Contributor

@vkryachko: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed ec2b145 link /test device-check-changed
smoke-tests ec2b145 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Sep 13, 2020
@vkryachko vkryachko deleted the vk.metalava-upgrade branch October 20, 2020 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants