Skip to content

Delete stale unused groovy files. #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Delete stale unused groovy files. #1814

merged 1 commit into from
Jul 23, 2020

Conversation

vkryachko
Copy link
Member

No description provided.

@vkryachko vkryachko requested a review from VinayGuthal July 23, 2020 14:48
@googlebot googlebot added the cla: yes Override cla label Jul 23, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 51.21% (b892f00) to 51.23% (ccad8a1c) by +0.02%.

    Filename Base (b892f00) Head (ccad8a1c) Diff
    ChildChangeAccumulator.java 83.87% 96.77% +12.90%
    DoubleNode.java 100.00% 88.89% -11.11%
  • firebase-storage

    SDK overall coverage changed from ? (b892f00) to 85.89% (ccad8a1c) by ?.

    Click to show coverage changes in 45 files.
    Filename Base (b892f00) Head (ccad8a1c) Diff
    ActivityLifecycleListener.java ? 74.14% ?
    AdaptiveStreamBuffer.java ? 84.62% ?
    CancelException.java ? 100.00% ?
    CancellableTask.java ? 100.00% ?
    ControllableTask.java ? 100.00% ?
    DeleteNetworkRequest.java ? 100.00% ?
    DeleteStorageTask.java ? 100.00% ?
    ExponentialBackoffSender.java ? 86.05% ?
    FileDownloadTask.java ? 77.60% ?
    FirebaseStorage.java ? 84.34% ?
    FirebaseStorageComponent.java ? 100.00% ?
    GetDownloadUrlTask.java ? 96.67% ?
    GetMetadataNetworkRequest.java ? 100.00% ?
    GetMetadataTask.java ? 84.62% ?
    GetNetworkRequest.java ? 100.00% ?
    HttpURLConnectionFactory.java ? 0.00% ?
    HttpURLConnectionFactoryImpl.java ? 50.00% ?
    ListNetworkRequest.java ? 100.00% ?
    ListResult.java ? 100.00% ?
    ListTask.java ? 85.19% ?
    NetworkRequest.java ? 89.29% ?
    OnPausedListener.java ? 0.00% ?
    OnProgressListener.java ? 0.00% ?
    ResumableNetworkRequest.java ? 100.00% ?
    ResumableUploadByteRequest.java ? 90.91% ?
    ResumableUploadCancelRequest.java ? 100.00% ?
    ResumableUploadQueryRequest.java ? 100.00% ?
    ResumableUploadStartRequest.java ? 95.00% ?
    Slashes.java ? 82.35% ?
    Sleeper.java ? 0.00% ?
    SleeperImpl.java ? 33.33% ?
    SmartHandler.java ? 87.50% ?
    StorageException.java ? 69.09% ?
    StorageMetadata.java ? 86.34% ?
    StorageReference.java ? 89.88% ?
    StorageRegistrar.java ? 100.00% ?
    StorageTask.java ? 84.89% ?
    StorageTaskManager.java ? 100.00% ?
    StorageTaskScheduler.java ? 100.00% ?
    StreamDownloadTask.java ? 88.89% ?
    TaskListenerImpl.java ? 100.00% ?
    UpdateMetadataNetworkRequest.java ? 100.00% ?
    UpdateMetadataTask.java ? 80.00% ?
    UploadTask.java ? 82.05% ?
    Util.java ? 65.57% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (ccad8a1c) is created by Prow via merging commits: b892f00 881436d.

@VinayGuthal
Copy link
Contributor

LGTM on test passing

@vkryachko vkryachko merged commit cc79cc6 into master Jul 23, 2020
@google-oss-bot
Copy link
Contributor

@vkryachko: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 881436d link /test check-changed
device-check-changed 881436d link /test device-check-changed
smoke-tests 881436d link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Aug 23, 2020
@vkryachko vkryachko deleted the vk.remove_stale_groovy branch October 20, 2020 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants