Skip to content

Properly release storage on exit #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Properly release storage on exit #1829

merged 1 commit into from
Jul 28, 2020

Conversation

kmandrika
Copy link
Contributor

Properly release the handler context using the allocator's release mechanics instead of delete.

@googlebot googlebot added the cla: yes Override cla label Jul 28, 2020
@kmandrika kmandrika requested a review from mrwillis21 July 28, 2020 17:42
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (57ffa1f) and head commit (42d803eb).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (42d803eb) is created by Prow via merging commits: 57ffa1f 59fd5f8.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-crashlytics-ndk

    Type Base (57ffa1f) Head (42d803eb) Diff
    aar 598 kB 599 kB +500 B (+0.1%)

Test Logs

Notes

Head commit (42d803eb) is created by Prow via merging commits: 57ffa1f 59fd5f8.

@kmandrika kmandrika merged commit f1e32c1 into master Jul 28, 2020
@kmandrika kmandrika deleted the fix-finalize branch July 28, 2020 18:15
@firebase firebase locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants