Fix Double Logging of FCM

[zwu52]

If shouldUploadScionMetrics and w shouldUploadFirelogAnalytics both evaluate to true, logToScion is called twice for a single message.

[google-oss-bot]

Coverage Report

Affected SDKs

No changes between base commit (f1e32c1) and head commit (7685c1d6).

Test Logs

• Base (f1e32c1a): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1288176373118013441
• Head (7685c1d6): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/1834/check-coverage-changed/1289250578911727622

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (7685c1d6) is created by Prow via merging commits: f1e32c1 0baa71b.

[google-oss-bot]

Binary Size Report

Affected SDKs

• firebase-messaging

  Type	Base (f1e32c1)	Head (7685c1d6)	Diff
  aar	174 kB	174 kB	-194 B (-0.1%)
  apk (aggressive)	493 kB	493 kB	-44 B (-0.0%)
  apk (release)	2.42 MB	2.42 MB	+216 B (+0.0%)

Test Logs

• Base (f1e32c1a): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-binary-size/1288176373118013440
• Head (7685c1d6): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/1834/binary-size/1289250578911727621

Notes

Head commit (7685c1d6) is created by Prow via merging commits: f1e32c1 0baa71b.

[google-oss-bot]

@zwu52: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
check-changed	0baa71b	link	/test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ciarand]

would be nice to have some tests that failed before this change