Address RTDB Lint violations

[schmidt-sebastian]

b/162720629

[google-oss-bot]

Coverage Report

Affected SDKs

• firebase-database

  SDK overall coverage changed from 51.16% (739dd16) to 51.13% (51e5ed79) by -0.03%.

  Click to show coverage changes in 23 files.

  Filename	Base (739dd16)	Head (51e5ed79)	Diff
  BooleanNode.java	100.00%	92.31%	-7.69%
  ChildChangeAccumulator.java	83.87%	96.67%	+12.80%
  ChildKey.java	90.20%	90.00%	-0.20%
  ChildrenNode.java	73.53%	73.40%	-0.13%
  CompoundWrite.java	87.96%	87.85%	-0.11%
  DefaultPersistenceManager.java	75.00%	74.76%	-0.24%
  DoubleNode.java	88.89%	100.00%	+11.11%
  IndexedFilter.java	95.65%	93.62%	-2.04%
  KeyIndex.java	83.33%	81.82%	-1.52%
  LeafNode.java	91.67%	91.55%	-0.12%
  LimitedFilter.java	97.70%	97.67%	-0.03%
  OperationSource.java	94.44%	94.12%	-0.33%
  Path.java	87.22%	87.12%	-0.10%
  PersistentConnectionImpl.java	18.09%	17.92%	-0.17%
  PushIdGenerator.java	74.07%	70.37%	-3.70%
  Query.java	50.30%	50.00%	-0.30%
  Repo.java	11.03%	10.88%	-0.16%
  SyncPoint.java	88.24%	88.12%	-0.12%
  SyncTree.java	64.48%	64.57%	+0.09%
  Tree.java	50.62%	50.00%	-0.62%
  View.java	84.78%	85.11%	+0.32%
  ViewProcessor.java	92.35%	92.10%	-0.26%
  WriteTree.java	76.80%	76.67%	-0.13%

Test Logs

• Base (739dd164): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1291449098364260354
• Head (51e5ed79): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/1866/check-coverage-changed/1292796143352156165

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (51e5ed79) is created by Prow via merging commits: 739dd16 c119960.

[google-oss-bot]

Binary Size Report

Affected SDKs

• firebase-database

  Type	Base (739dd16)	Head (51e5ed79)	Diff
  aar	482 kB	479 kB	-3.19 kB (-0.7%)
  apk (release)	1.08 MB	1.08 MB	+1.28 kB (+0.1%)

Test Logs

• Base (739dd164): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-binary-size/1291449098355871744
• Head (51e5ed79): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/1866/binary-size/1292796143352156168

Notes

Head commit (51e5ed79) is created by Prow via merging commits: 739dd16 c119960.

[google-oss-bot]

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
smoke-tests	c119960	link	/test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.