Skip to content

Bump kotlin-gradle-plugin from 1.3.72 to 1.4.0 #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 17, 2020

Bumps kotlin-gradle-plugin from 1.3.72 to 1.4.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps kotlin-gradle-plugin from 1.3.72 to 1.4.0.

Signed-off-by: dependabot[bot] <[email protected]>
@google-oss-bot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rlazo
Copy link
Collaborator

rlazo commented Aug 17, 2020

/ok-to-test

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-common-ktx

    Type Base (66dd76d) Head (fd95e654) Diff
    apk (aggressive) 90.3 kB 89.3 kB -1.02 kB (-1.1%)
    apk (release) 1.10 MB 1.16 MB +52.8 kB (+4.8%)
  • firebase-config-ktx

    Type Base (66dd76d) Head (fd95e654) Diff
    apk (aggressive) 190 kB 189 kB -1.03 kB (-0.5%)
    apk (release) 1.49 MB 1.55 MB +52.9 kB (+3.5%)
  • firebase-crashlytics-ktx

    Type Base (66dd76d) Head (fd95e654) Diff
    apk (aggressive) 340 kB 339 kB -1.03 kB (-0.3%)
    apk (release) 1.52 MB 1.57 MB +54.1 kB (+3.6%)
  • firebase-database-ktx

    Type Base (66dd76d) Head (fd95e654) Diff
    apk (aggressive) 295 kB 294 kB -1.02 kB (-0.3%)
    apk (release) 1.56 MB 1.61 MB +53.6 kB (+3.4%)
  • firebase-dynamic-links-ktx

    Type Base (66dd76d) Head (fd95e654) Diff
    apk (aggressive) 320 kB 319 kB -1.05 kB (-0.3%)
    apk (release) 1.41 MB 1.46 MB +53.8 kB (+3.8%)
  • firebase-firestore-ktx

    Type Base (66dd76d) Head (fd95e654) Diff
    apk (aggressive) 426 kB 425 kB -1.04 kB (-0.2%)
    apk (release) 3.62 MB 3.67 MB +54.8 kB (+1.5%)
  • firebase-functions-ktx

    Type Base (66dd76d) Head (fd95e654) Diff
    apk (aggressive) 367 kB 366 kB -1.03 kB (-0.3%)
    apk (release) 1.64 MB 1.69 MB +53.3 kB (+3.3%)
  • firebase-inappmessaging-display-ktx

    Type Base (66dd76d) Head (fd95e654) Diff
    apk (aggressive) 1.44 MB 1.43 MB -1.14 kB (-0.1%)
    apk (release) 5.00 MB 5.06 MB +52.3 kB (+1.0%)
  • firebase-inappmessaging-ktx

    Type Base (66dd76d) Head (fd95e654) Diff
    apk (aggressive) 627 kB 626 kB -1.02 kB (-0.2%)
    apk (release) 3.77 MB 3.82 MB +54.7 kB (+1.5%)
  • firebase-installations

    Type Base (66dd76d) Head (fd95e654) Diff
    aar 59.2 kB 59.2 kB -1 B (-0.0%)
  • firebase-storage-ktx

    Type Base (66dd76d) Head (fd95e654) Diff
    apk (aggressive) 295 kB 294 kB -1.02 kB (-0.3%)
    apk (release) 1.43 MB 1.49 MB +52.2 kB (+3.6%)

Test Logs

Notes

Head commit (fd95e654) is created by Prow via merging commits: 66dd76d d7af21b.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 51.14% (66dd76d) to 51.07% (fd95e654) by -0.07%.

    Filename Base (66dd76d) Head (fd95e654) Diff
    ChildChangeAccumulator.java 96.67% 83.33% -13.33%
    DoubleNode.java 100.00% 88.24% -11.76%
  • firebase-messaging

    SDK overall coverage changed from 83.77% (66dd76d) to 83.91% (fd95e654) by +0.14%.

    Filename Base (66dd76d) Head (fd95e654) Diff
    TopicsSubscriber.java 89.66% 91.38% +1.72%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (fd95e654) is created by Prow via merging commits: 66dd76d d7af21b.

@google-oss-bot
Copy link
Contributor

@dependabot[bot]: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests d7af21b link /test smoke-tests
device-check-changed d7af21b link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo rlazo merged commit a69ede1 into master Aug 17, 2020
@dependabot dependabot bot deleted the dependabot/gradle/org.jetbrains.kotlin-kotlin-gradle-plugin-1.4.0 branch August 17, 2020 15:38
@firebase firebase locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants