Skip to content

Treat ABORTED writes as retryable #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2019
Merged

Treat ABORTED writes as retryable #189

merged 3 commits into from
Jan 11, 2019

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Jan 11, 2019

This corresponds to a server-side change that will be released for the v1 protocol only (see b/119437764).

This is a port of firebase/firebase-js-sdk#1456.

This corresponds to a server-side change that will be released for the v1 protocol only (see b/119437764).

This is a port of firebase/firebase-js-sdk#1456.
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@mikelehen mikelehen assigned wilhuff and unassigned mikelehen Jan 11, 2019
@wilhuff
Copy link
Contributor Author

wilhuff commented Jan 11, 2019

/retest

@wilhuff wilhuff merged commit aa19fc6 into master Jan 11, 2019
@wilhuff wilhuff deleted the wilhuff/aborted branch January 11, 2019 23:10
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants