Skip to content

Add FCM ktx library. #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2020
Merged

Add FCM ktx library. #1899

merged 3 commits into from
Aug 26, 2020

Conversation

vkryachko
Copy link
Member

No description provided.

@googlebot googlebot added cla: yes Override cla labels Aug 19, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 19, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 51.07% (4e9494b) to 51.13% (35ed99ef) by +0.06%.

    Filename Base (4e9494b) Head (35ed99ef) Diff
    BooleanNode.java 92.31% 100.00% +7.69%
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%

  • firebase-messaging

    SDK overall coverage changed from 83.77% (4e9494b) to 83.43% (35ed99ef) by -0.35%.

    Filename Base (4e9494b) Head (35ed99ef) Diff
    FirebaseMessaging.java 66.67% 65.00% -1.67%
    RemoteMessage.java 98.67% 95.48% -3.18%

  • firebase-messaging-ktx

    SDK overall coverage changed from ? (4e9494b) to 50.00% (35ed99ef) by ?.

    Filename Base (4e9494b) Head (35ed99ef) Diff
    Messaging.kt ? 50.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (35ed99ef) is created by Prow via merging commits: 4e9494b 6f5887e.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 19, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-installations

    Type Base (4e9494b) Head (35ed99ef) Diff
    aar 59.2 kB 59.2 kB +4 B (+0.0%)

  • firebase-messaging

    Type Base (4e9494b) Head (35ed99ef) Diff
    aar 174 kB 174 kB +313 B (+0.2%)
    apk (release) 2.43 MB 2.43 MB +48 B (+0.0%)

  • firebase-messaging-directboot

    Type Base (4e9494b) Head (35ed99ef) Diff
    aar 10.4 kB 10.4 kB +65 B (+0.6%)
    apk (release) 2.31 MB 2.31 MB -4 B (-0.0%)

  • firebase-messaging-ktx

    Type Base (4e9494b) Head (35ed99ef) Diff
    aar ? 6.60 kB ? (?)
    apk (aggressive) ? 508 kB ? (?)
    apk (release) ? 2.96 MB ? (?)

Test Logs

Notes

Head commit (35ed99ef) is created by Prow via merging commits: 4e9494b 6f5887e.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 20, 2020 •
edited
Loading

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 6f5887e link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko marked this pull request as ready for review August 26, 2020 14:46
@vkryachko vkryachko requested a review from rlazo August 26, 2020 14:46
@vkryachko vkryachko merged commit dc90128 into master Aug 26, 2020
@firebase firebase locked and limited conversation to collaborators Sep 26, 2020
@vkryachko vkryachko deleted the vk.fcm_ktx branch October 20, 2020 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @rlazo @googlebot