Change timestampsInSnapshots default to true and deprecate the setting. #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
approved these changes
Jan 11, 2019
| @@ -131,7 +131,28 @@ public Builder setPersistenceEnabled(boolean value) { | |||
| * @return A settings object on which the return type for timestamp fields is configured as | |||
| * specified by the given {@code value}. | |||
| */ | |||
| /** | |||
There was a problem hiding this comment.
Uh... This seems like you added the new but didn't remove the old?
There was a problem hiding this comment.
Gah, sorry. I should have sanity-checked the diff before sending for review but I was too busy not running the unit tests.
|
/retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.