Skip to content

Address reference doc review comments #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2020
Merged

Address reference doc review comments #1919

merged 1 commit into from
Aug 27, 2020

Conversation

samtstern
Copy link
Contributor

Addressing @rachelsaunders comments on http://cl/328381521

@googlebot googlebot added cla: yes Override cla labels Aug 27, 2020
wilhuff
wilhuff approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (dc90128) and head commit (99aaea47).

Test Logs

Notes

Head commit (99aaea47) is created by Prow via merging commits: dc90128 8b18c2e.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 51.05% (dc90128) to 51.09% (99aaea47) by +0.05%.

    Filename Base (dc90128) Head (99aaea47) Diff
    BooleanNode.java 92.31% 100.00% +7.69%
    DoubleNode.java 88.24% 100.00% +11.76%
    ViewProcessor.java 91.79% 92.10% +0.30%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (99aaea47) is created by Prow via merging commits: dc90128 8b18c2e.

@samtstern samtstern merged commit c99b61c into master Aug 27, 2020
@firebase firebase locked and limited conversation to collaborators Sep 27, 2020
@kaibolay kaibolay deleted the ss-cl-328381521-comments branch September 14, 2022 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

@rachelsaunders rachelsaunders rachelsaunders approved these changes

Assignees

@rachelsaunders rachelsaunders

Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samtstern @google-oss-bot @wilhuff @rachelsaunders @googlebot