Skip to content

lazy initialization of heartbeat #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2020
Merged

lazy initialization of heartbeat #1925

merged 2 commits into from
Aug 31, 2020

Conversation

VinayGuthal
Copy link
Contributor

Lazy initialization of heartbeat.

@googlebot googlebot added the cla: yes Override cla label Aug 31, 2020
@VinayGuthal VinayGuthal requested a review from vkryachko August 31, 2020 17:16
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 31, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-installations

    Type Base (c99b61c) Head (f8938862) Diff
    aar 59.2 kB 59.4 kB +202 B (+0.3%)
    apk (aggressive) 76.4 kB 76.4 kB +8 B (+0.0%)
    apk (release) 648 kB 648 kB +40 B (+0.0%)

Test Logs

Notes

Head commit (f8938862) is created by Prow via merging commits: c99b61c ea2b5d1.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 31, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-installations

    SDK overall coverage changed from ? (c99b61c) to 57.27% (f8938862) by ?.

    Click to show coverage changes in 19 files.
    Filename Base (c99b61c) Head (f8938862) Diff
    AutoValue_InstallationResponse.java ? 42.86% ?
    AutoValue_PersistedInstallationEntry.java ? 61.18% ?
    AutoValue_TokenResult.java ? 45.65% ?
    AwaitListener.java ? 0.00% ?
    CrossProcessLock.java ? 51.85% ?
    FirebaseInstallationServiceClient.java ? 5.07% ?
    FirebaseInstallations.java ? 97.87% ?
    FirebaseInstallationsException.java ? 76.92% ?
    FirebaseInstallationsRegistrar.java ? 100.00% ?
    GetAuthTokenListener.java ? 90.00% ?
    GetIdListener.java ? 70.00% ?
    IidStore.java ? 44.78% ?
    InstallationResponse.java ? 100.00% ?
    PersistedInstallation.java ? 96.77% ?
    PersistedInstallationEntry.java ? 100.00% ?
    RandomFidGenerator.java ? 20.00% ?
    StateListener.java ? 0.00% ?
    TokenResult.java ? 100.00% ?
    Utils.java ? 100.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (f8938862) is created by Prow via merging commits: c99b61c ea2b5d1.

@VinayGuthal
Copy link
Contributor Author

/test check-changed

@VinayGuthal VinayGuthal merged commit 2056bfc into master Aug 31, 2020
@VinayGuthal VinayGuthal deleted the heartbeat_lazy_update branch August 31, 2020 18:51
@firebase firebase locked and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VinayGuthal @google-oss-bot @vkryachko @googlebot