Extract core encoders api into a separate library. #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decouples the api from the json implementation, enabling creation of other formats in the future. This is modeled as a breaking change even though it won't have any developer impact.
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (8836428d) is created by Prow via merging commits: 2056bfc 927c60a. |
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (8836428d) is created by Prow via merging commits: 2056bfc 927c60a. |
|
/test check-changed |
rlazo
reviewed
Sep 1, 2020
|
/test device-check-changed |
rlazo
approved these changes
Sep 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples the api from the json implementation, enabling creation
of other formats in the future.
This is modeled as a breaking change even though it won't have any
developer impact.