Skip to content

Clear setInManifest flag if data collection value is set by API #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

mrwillis21
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Sep 8, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (24a07db) and head commit (95b5bff9).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (95b5bff9) is created by Prow via merging commits: 24a07db 15b2980.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-crashlytics

    Type Base (24a07db) Head (95b5bff9) Diff
    aar 410 kB 410 kB +6 B (+0.0%)
    apk (release) 1.04 MB 1.04 MB +88 B (+0.0%)
  • firebase-installations

    Type Base (24a07db) Head (95b5bff9) Diff
    aar 59.4 kB 59.4 kB -2 B (-0.0%)

Test Logs

Notes

Head commit (95b5bff9) is created by Prow via merging commits: 24a07db 15b2980.

@mrwillis21 mrwillis21 merged commit 17c9403 into master Sep 8, 2020
@mrwillis21 mrwillis21 deleted the fix-datacollectionarbiter-setinmanifestflag branch September 8, 2020 17:37
@firebase firebase locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants