Skip to content

Fix NotInFilter matching #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2020
Merged

Fix NotInFilter matching #1947

merged 1 commit into from
Sep 9, 2020

Conversation

thebrianchen
Copy link

whereNotIn(path, Array(null)) always returns an empty list, which means that NotInFilter.matches() needs to also not match any documents if the filter's value contains null.

Also added a null serialization test for notIn.

@thebrianchen thebrianchen self-assigned this Sep 8, 2020
@googlebot googlebot added the cla: yes Override cla label Sep 8, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (a902780) Head (8be5a53e) Diff
    aar ? 35.4 kB ? (?)
    apk (aggressive) ? 74.6 kB ? (?)
    apk (release) ? 627 kB ? (?)

  • firebase-components

    Type Base (a902780) Head (8be5a53e) Diff
    aar ? 34.5 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 25.2 kB ? (?)

  • firebase-database-collection

    Type Base (a902780) Head (8be5a53e) Diff
    aar ? 34.2 kB ? (?)
    apk (aggressive) ? 268 kB ? (?)
    apk (release) ? 901 kB ? (?)

  • firebase-firestore

    Type Base (a902780) Head (8be5a53e) Diff
    aar ? 999 kB ? (?)
    apk (aggressive) ? 411 kB ? (?)
    apk (release) ? 3.13 MB ? (?)

  • protolite-well-known-types

    Type Base (a902780) Head (8be5a53e) Diff
    aar ? 998 kB ? (?)
    apk (aggressive) ? 132 kB ? (?)
    apk (release) ? 659 kB ? (?)

Test Logs

Notes

Head commit (8be5a53e) is created by Prow via merging commits: a902780 45f15c6.

@thebrianchen
Copy link
Author

/test smoke-tests

@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen Sep 8, 2020
@thebrianchen thebrianchen requested a review from wilhuff September 8, 2020 23:06
wilhuff
wilhuff approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Sep 9, 2020
@thebrianchen thebrianchen merged commit 2d829f3 into master Sep 9, 2020
@thebrianchen thebrianchen deleted the bc/ne-fix-notin branch September 9, 2020 19:07
@thebrianchen thebrianchen mentioned this pull request Sep 9, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebrianchen @google-oss-bot @wilhuff @googlebot