Skip to content

Add a changelog entry for Firestore platform logging #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2020
Merged

Add a changelog entry for Firestore platform logging #2018

merged 2 commits into from
Sep 29, 2020

Conversation

var-const
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Sep 29, 2020
@google-cla google-cla bot added the cla: yes Override cla label Sep 29, 2020
@var-const var-const requested a review from wu-hui September 29, 2020 20:49
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 29, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (12ae453) and head commit (1300915d).

Test Logs

Notes

Head commit (1300915d) is created by Prow via merging commits: 12ae453 a40115b.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 29, 2020 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (12ae453) and head commit (1300915d).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (1300915d) is created by Prow via merging commits: 12ae453 a40115b.

wu-hui
wu-hui reviewed Sep 29, 2020
View reviewed changes
firebase-firestore/CHANGELOG.md
@@ -5,6 +5,7 @@
documents where a specified field's value does not equal the specified value.
Neither query operator will match documents where the specified field is not
present.
- [changed] Added new internal HTTP headers to the gRPC connection.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move NotIn under 21.6.0 and yours under 21.6.1?

@var-const var-const merged commit c8098ad into master Sep 29, 2020
@google-oss-bot
Copy link
Contributor

@var-const: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed a40115b link /test device-check-changed
smoke-tests a40115b link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Oct 30, 2020
@kaibolay kaibolay deleted the varconst/changelogging branch September 14, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

Labels
api: firestore cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@var-const @google-oss-bot @wu-hui @googlebot