Skip to content

Add StrictModeRule for use by SDKs. #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Add StrictModeRule for use by SDKs. #2023

merged 3 commits into from
Sep 30, 2020

Conversation

vkryachko
Copy link
Member

No description provided.

@vkryachko vkryachko requested a review from rlazo September 30, 2020 18:11
@googlebot googlebot added the cla: yes Override cla label Sep 30, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 30, 2020

Binary Size Report

Affected SDKs

No changes between base commit (5bc4d96) and head commit (8d85f33e).

Test Logs

Notes

Head commit (8d85f33e) is created by Prow via merging commits: 5bc4d96 97d7de3.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 30, 2020

Coverage Report

Affected SDKs

  • firebase-storage

    SDK overall coverage changed from 85.48% (5bc4d96) to 85.44% (8d85f33e) by -0.04%.

    Filename Base (5bc4d96) Head (8d85f33e) Diff
    StreamDownloadTask.java 88.89% 88.41% -0.48%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (8d85f33e) is created by Prow via merging commits: 5bc4d96 97d7de3.

@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 97d7de3 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko merged commit eb7cae1 into master Sep 30, 2020
@vkryachko vkryachko deleted the vk.strict_mode_rule branch October 20, 2020 21:56
@firebase firebase locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants