Skip to content

Remove timestampInSnapshots Setting #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2020
Merged

Remove timestampInSnapshots Setting #2026

merged 4 commits into from
Oct 9, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Sep 30, 2020 •
edited
Loading

Snapshot data will now always use Timestamp values. Use Timestamp.toDate() to convert to java.util.Date if required.

timestampsInSnapshots was deprecated in January 2019 and has defaulted to true since then.

Port of firebase/firebase-ios-sdk#6622

@schmidt-sebastian
Remove timestampInSnapshots
2669b3f 
DO NOT SUBMIT until Oct 1
@google-cla google-cla bot added the cla: yes Override cla label Sep 30, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 30, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (690d119) Head (ffac0bfe) Diff
    aar 999 kB 999 kB -429 B (-0.0%)
    apk (release) 3.14 MB 3.13 MB -208 B (-0.0%)

Test Logs

Notes

Head commit (ffac0bfe) is created by Prow via merging commits: 690d119 83c4cf7.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 30, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 46.89% (690d119) to 46.88% (ffac0bfe) by -0.01%.

    Filename Base (690d119) Head (ffac0bfe) Diff
    DocumentSnapshot.java 36.00% 36.84% +0.84%
    FirebaseFirestoreSettings.java 67.24% 68.63% +1.39%
    UserDataWriter.java 54.72% 51.02% -3.70%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (ffac0bfe) is created by Prow via merging commits: 690d119 83c4cf7.

@schmidt-sebastian schmidt-sebastian changed the title Remove timestampInSnapshots Remove timestampInSnapshots Setting Oct 2, 2020
thebrianchen
thebrianchen approved these changes Oct 9, 2020
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schmidt-sebastian schmidt-sebastian merged commit f9519f2 into master Oct 9, 2020
@firebase firebase locked and limited conversation to collaborators Nov 9, 2020
@kaibolay kaibolay deleted the mrschmidt/timestampsinsnapshots branch September 14, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @thebrianchen