-
Notifications
You must be signed in to change notification settings - Fork 625
LibraryVersion reporting #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e7af8fc
WIP Initial PlatformInfo implementation.
vkryachko 7280e3e
Refactoring and testing
ashwinraghav 34e7600
Moving deps to compile only
ashwinraghav 132c2e5
Merge branch 'master' into multi_platform_info
ashwinraghav 28516a6
Formatting
ashwinraghav 56db574
Review feedback
ashwinraghav 044afd2
Review feedback 2
ashwinraghav ee7539f
Removing swp
ashwinraghav 794be17
MOving to api from compileOnly
ashwinraghav f33a6c7
Review feedback 3
ashwinraghav 3bdff0b
Added library prefix
ashwinraghav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
...se-common/src/main/java/com/google/firebase/platforminfo/DefaultPlatformInfoSupplier.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// Copyright 2018 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.platforminfo; | ||
|
||
import com.google.firebase.components.Component; | ||
import com.google.firebase.components.Dependency; | ||
import java.util.Iterator; | ||
import java.util.Set; | ||
|
||
public class DefaultPlatformInfoSupplier implements PlatformInfoSupplier { | ||
private final String tokens; | ||
|
||
private DefaultPlatformInfoSupplier(Set<PlatformInfoToken> tokens) { | ||
this.tokens = toUserAgent(tokens); | ||
} | ||
|
||
@Override | ||
public String getUserAgent() { | ||
if (PlatformInfoCompat.getGlobalInfo().isEmpty()) { | ||
return tokens; | ||
} | ||
|
||
return tokens + ' ' + toUserAgent(PlatformInfoCompat.getGlobalInfo()); | ||
} | ||
|
||
private static String toUserAgent(Set<PlatformInfoToken> tokens) { | ||
StringBuilder sb = new StringBuilder(); | ||
Iterator<PlatformInfoToken> iterator = tokens.iterator(); | ||
while (iterator.hasNext()) { | ||
PlatformInfoToken token = iterator.next(); | ||
sb.append(token.key).append('/').append(token.value); | ||
if (iterator.hasNext()) { | ||
sb.append(' '); | ||
} | ||
} | ||
return sb.toString(); | ||
} | ||
|
||
public static Component<PlatformInfoSupplier> component() { | ||
return Component.builder(PlatformInfoSupplier.class) | ||
.add(Dependency.setOf(PlatformInfoToken.class)) | ||
.factory(c -> new DefaultPlatformInfoSupplier(c.setOf(PlatformInfoToken.class))) | ||
.build(); | ||
} | ||
} |
25 changes: 25 additions & 0 deletions
25
firebase-common/src/main/java/com/google/firebase/platforminfo/PlatformInfo.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// Copyright 2018 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.platforminfo; | ||
|
||
import com.google.firebase.components.Component; | ||
|
||
public class PlatformInfo { | ||
private PlatformInfo() {} | ||
|
||
public static Component<?> component(String key, String value) { | ||
return Component.intoSet(new PlatformInfoToken(key, value), PlatformInfoToken.class); | ||
} | ||
} |
37 changes: 37 additions & 0 deletions
37
firebase-common/src/main/java/com/google/firebase/platforminfo/PlatformInfoCompat.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// Copyright 2018 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.platforminfo; | ||
|
||
import java.util.Collections; | ||
import java.util.HashSet; | ||
import java.util.Set; | ||
|
||
public class PlatformInfoCompat { | ||
private static final Set<PlatformInfoToken> infos = new HashSet<>(); | ||
|
||
private PlatformInfoCompat() {} | ||
|
||
public static void register(String key, String value) { | ||
synchronized (infos) { | ||
infos.add(new PlatformInfoToken(key, value)); | ||
} | ||
} | ||
|
||
static Set<PlatformInfoToken> getGlobalInfo() { | ||
synchronized (infos) { | ||
return Collections.unmodifiableSet(infos); | ||
} | ||
} | ||
} |
19 changes: 19 additions & 0 deletions
19
firebase-common/src/main/java/com/google/firebase/platforminfo/PlatformInfoSupplier.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Copyright 2018 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.platforminfo; | ||
|
||
public interface PlatformInfoSupplier { | ||
String getUserAgent(); | ||
} |
26 changes: 26 additions & 0 deletions
26
firebase-common/src/main/java/com/google/firebase/platforminfo/PlatformInfoToken.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// Copyright 2018 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.platforminfo; | ||
|
||
/** The class is not public to ensure other components cannot depend on it. */ | ||
class PlatformInfoToken { | ||
ashwinraghav marked this conversation as resolved.
Show resolved
Hide resolved
|
||
final String key; | ||
final String value; | ||
|
||
PlatformInfoToken(String key, String value) { | ||
ashwinraghav marked this conversation as resolved.
Show resolved
Hide resolved
|
||
this.key = key; | ||
this.value = value; | ||
} | ||
} |
16 changes: 16 additions & 0 deletions
16
firebase-common/src/main/java/com/google/firebase/platforminfo/package-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Copyright 2018 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
/** @hide */ | ||
package com.google.firebase.platforminfo; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.