Skip to content

Catch OverlappingFilelockException to prevent app crashes #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Conversation

ankitaj224
Copy link
Contributor

In some Android 7 & 8 devices trying to acquire a file lock crashes with OverlappingFilelockException.

Context : https://docs.google.com/document/d/1IxqlppPK9KBr6Yb94AhGIOXA_XX-u2D7NMD80MolIyA/edit#

@google-cla google-cla bot added the cla: yes Override cla label Oct 2, 2020
@googlebot googlebot added the cla: yes Override cla label Oct 2, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 2, 2020

Binary Size Report

Affected SDKs

  • firebase-installations

    Type Base (f9519f2) Head (7b04f6f1) Diff
    aar 62.2 kB 62.2 kB +26 B (+0.0%)
    apk (release) 649 kB 649 kB +48 B (+0.0%)

Test Logs

Notes

Head commit (7b04f6f1) is created by Prow via merging commits: f9519f2 ccd94ef.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 2, 2020

Coverage Report

Affected SDKs

No changes between base commit (f9519f2) and head commit (7b04f6f1).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (7b04f6f1) is created by Prow via merging commits: f9519f2 ccd94ef.

@ankitaj224
Copy link
Contributor Author

/test smoke-tests

@google-oss-bot
Copy link
Contributor

@ankitaj224: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests ccd94ef link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ankitaj224 ankitaj224 merged commit da5efbf into master Oct 12, 2020
@ankitaj224 ankitaj224 deleted the ofleFix branch October 12, 2020 22:04
@firebase firebase locked and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants