Skip to content

Add additional platform signals to UserAgent. #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2020
Merged

Add additional platform signals to UserAgent. #2112

merged 4 commits into from
Oct 29, 2020

Conversation

vkryachko
Copy link
Member

No description provided.

@vkryachko vkryachko requested a review from VinayGuthal October 27, 2020 18:22
@google-cla google-cla bot added the cla: yes Override cla label Oct 27, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (da18188) Head (2778614c) Diff
    aar ? 40.7 kB ? (?)
    apk (aggressive) ? 75.7 kB ? (?)
    apk (release) ? 628 kB ? (?)

  • firebase-components

    Type Base (da18188) Head (2778614c) Diff
    aar ? 34.7 kB ? (?)
    apk (aggressive) ? 8.68 kB ? (?)
    apk (release) ? 25.2 kB ? (?)

Test Logs

Notes

Head commit (2778614c) is created by Prow via merging commits: da18188 f8ae811.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-common

    SDK overall coverage changed from 44.11% (da18188) to 56.73% (2778614c) by +12.61%.

    Filename Base (da18188) Head (2778614c) Diff
    AutoValue_LibraryVersion.java 25.00% 58.33% +33.33%
    DefaultUserAgentPublisher.java 18.18% 95.45% +77.27%
    FirebaseApp.java 52.17% 51.98% -0.19%
    FirebaseCommonRegistrar.java ? 95.74% ?
    FirebaseOptions.java 29.17% 31.94% +2.78%
    GlobalLibraryVersionRegistrar.java 0.00% 75.00% +75.00%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (2778614c) is created by Prow via merging commits: da18188 f8ae811.

maksymmalyhin
maksymmalyhin approved these changes Oct 27, 2020
View reviewed changes
Copy link

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the logic in general, sorry cannot provide too much feedback on Android specifics. One question.

VinayGuthal
VinayGuthal approved these changes Oct 28, 2020
View reviewed changes
@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed f8ae811 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko merged commit 3932951 into master Oct 29, 2020
@vkryachko vkryachko deleted the vk.platform_logging branch October 29, 2020 17:47
@firebase firebase locked and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@VinayGuthal VinayGuthal VinayGuthal approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @maksymmalyhin @VinayGuthal