Instrument Gradle build with metrics. #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically we now report latency and success/failure of each individual Gradle task.
|
/retest |
|
/retest |
| task.getExtensions().add(METRICS_ELAPSED_TIME, System.currentTimeMillis() - startTime); | ||
| } | ||
|
|
||
| private static long getElapsed(Task task) { |
There was a problem hiding this comment.
Nit: We could either have an equivalent getStart() or write this inline as well
There was a problem hiding this comment.
fwiw I did not add it because getStart() is needed only in recordElapsed() which is a pretty simple function, otoh getElapsed() is used in a graph traversal so I wanted to keep things simple and readable there.
| Set<Task> visited = new HashSet<>(); | ||
|
|
||
| long totalElapsed = 0; | ||
| while (!queue.isEmpty()) { |
There was a problem hiding this comment.
It's not often you see graph traversal in a code review 🤣
buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/ci/metrics/MetricsPlugin.java
Outdated
Show resolved
Hide resolved
allisonbm92
reviewed
Jan 30, 2019
...Src/src/main/groovy/com/google/firebase/gradle/plugins/ci/metrics/DrainingBuildListener.java
Show resolved
Hide resolved
buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/ci/metrics/StackdriverMetrics.java
Show resolved
Hide resolved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
vkryachko
force-pushed
the
vk.opencensus
branch
from
363dd7d to
87375a3
Compare
|
/retest |
allisonbm92
approved these changes
Jan 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically we now report latency and success/failure of each
individual Gradle task.