Skip to content

Include runtimeOnly dependencies in javadocClasspath. #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2020
Merged

Include runtimeOnly dependencies in javadocClasspath. #2151

merged 1 commit into from
Nov 5, 2020

Conversation

vkryachko
Copy link
Member

This makes such dependencies' symbols available during javadoc/dokka
runs.

@vkryachko
Include runtimeOnly dependencies in javadocClasspath.
ffcd160 
This makes such dependencies' symbols available during javadoc/dokka
runs.
@vkryachko vkryachko requested a review from rlazo November 5, 2020 20:52
@google-cla google-cla bot added the cla: yes Override cla label Nov 5, 2020
@googlebot googlebot added the cla: yes Override cla label Nov 5, 2020
@vkryachko vkryachko merged commit ece6a47 into master Nov 5, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 51.02% (9c2cc45) to 51.01% (b0f35f7d) by -0.01%.

    Filename Base (9c2cc45) Head (b0f35f7d) Diff
    QueryParams.java 89.76% 89.16% -0.60%

  • firebase-messaging

    SDK overall coverage changed from ? (9c2cc45) to 83.43% (b0f35f7d) by ?.

    Click to show coverage changes in 23 files.
    Filename Base (9c2cc45) Head (b0f35f7d) Diff
    CommonNotificationBuilder.java ? 91.63% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 80.00% ?
    ExecutorFactory.java ? 0.00% ?
    FcmExecutors.java ? 85.71% ?
    FirebaseMessaging.java ? 65.00% ?
    FirebaseMessagingRegistrar.java ? 83.33% ?
    FirebaseMessagingService.java ? 94.79% ?
    FirelogAnalyticsEvent.java ? 26.67% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 63.93% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    RemoteMessage.java ? 95.48% ?
    RemoteMessageCreator.java ? 88.89% ?
    SendException.java ? 100.00% ?
    SharedPreferencesQueue.java ? 98.44% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 89.66% ?
    TopicsSyncTask.java ? 53.33% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (b0f35f7d) is created by Prow via merging commits: 9c2cc45 ffcd160.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-installations

    Type Base (9c2cc45) Head (b0f35f7d) Diff
    aar 62.0 kB 62.0 kB -1 B (-0.0%)

Test Logs

Notes

Head commit (b0f35f7d) is created by Prow via merging commits: 9c2cc45 ffcd160.

@firebase firebase locked and limited conversation to collaborators Dec 6, 2020
@vkryachko vkryachko deleted the vk.javadoc_classpath branch January 21, 2021 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @rlazo @googlebot