Skip to content

Cleaning customer-lint check from FIS SDK. #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Cleaning customer-lint check from FIS SDK. #2196

merged 1 commit into from
Nov 23, 2020

Conversation

ankitaj224
Copy link
Contributor

No description provided.

@ankitaj224 ankitaj224 requested a review from vkryachko November 23, 2020 18:14
@googlebot googlebot added the cla: yes Override cla label Nov 23, 2020
@google-oss-bot
Copy link
Contributor

@ankitaj224: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 2f1c4a2 link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.30% (e000228) to 50.27% (3c86966d) by -0.03%.

    Filename Base (e000228) Head (3c86966d) Diff
    RetryHelper.java 74.19% 70.97% -3.23%
    ViewProcessor.java 92.10% 91.79% -0.30%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (3c86966d) is created by Prow via merging commits: e000228 2f1c4a2.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-installations

    Type Base (e000228) Head (3c86966d) Diff
    aar 62.0 kB 55.4 kB -6.68 kB (-10.8%)

Test Logs

Notes

Head commit (3c86966d) is created by Prow via merging commits: e000228 2f1c4a2.

@ankitaj224 ankitaj224 merged commit c7d3073 into master Nov 23, 2020
@firebase firebase locked and limited conversation to collaborators Dec 24, 2020
@kaibolay kaibolay deleted the cleanUpLint branch September 15, 2022 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants