Remove SimpleQueryEngine #2203
Merged
Remove SimpleQueryEngine #2203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/removesimplequeryengine
branch
from
106ebd9 to
43b4719
Compare
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (f73f9226) is created by Prow via merging commits: f902fe2 2759864. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (f73f9226) is created by Prow via merging commits: f902fe2 2759864. |
dconeybe
approved these changes
Nov 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of firebase/firebase-js-sdk#4117. It removes SimpleQueryEngine and reduces the test matrix for LocalStoreTest. Since Android also has an IndexedQueryEngine, it keeps the
QueryEngineinterface.