Skip to content

Update protobuf dep to 3.14 #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2020
Merged

Update protobuf dep to 3.14 #2207

merged 1 commit into from
Nov 30, 2020

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Nov 27, 2020

No description provided.

@googlebot googlebot added the cla: yes Override cla label Nov 27, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.46% (13b12ca) to 50.35% (dfde5f86) by -0.11%.

    Filename Base (13b12ca) Head (dfde5f86) Diff
    BooleanNode.java 92.31% 100.00% +7.69%
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%
    DoubleNode.java 88.24% 100.00% +11.76%
    RetryHelper.java 74.19% 70.97% -3.23%
    WebSocket.java 38.00% 34.50% -3.50%
    WebsocketConnection.java 36.93% 32.39% -4.55%

  • firebase-firestore

    SDK overall coverage changed from 47.00% (13b12ca) to 46.90% (dfde5f86) by -0.10%.

    Click to show coverage changes in 17 files.
    Filename Base (13b12ca) Head (dfde5f86) Diff
    ArrayValue.java 49.06% 48.60% -0.46%
    Cursor.java 35.59% 35.29% -0.30%
    Document.java 30.90% 30.34% -0.56%
    DocumentChange.java 34.27% 35.17% +0.91%
    DocumentDelete.java 34.11% 34.62% +0.51%
    DocumentMask.java 41.11% 40.66% -0.45%
    DocumentRemove.java 28.68% 29.23% +0.55%
    DocumentTransform.java 29.95% 29.66% -0.29%
    MapValue.java 54.00% 53.00% -1.00%
    Precondition.java 39.32% 38.46% -0.85%
    StructuredQuery.java 33.38% 32.90% -0.48%
    Target.java 27.09% 26.58% -0.51%
    TargetChange.java 35.03% 35.35% +0.33%
    Value.java 45.65% 45.38% -0.26%
    Write.java 38.28% 37.89% -0.39%
    WriteRequest.java 10.45% 10.41% -0.05%
    WriteResponse.java 11.76% 11.70% -0.07%

  • firebase-inappmessaging

    SDK overall coverage changed from 37.42% (13b12ca) to 37.42% (dfde5f86) by -0.00%.

    Filename Base (13b12ca) Head (dfde5f86) Diff
    CampaignImpressionList.java 38.68% 39.25% +0.57%
    CampaignProto.java 27.38% 27.48% +0.10%
    CommonTypesProto.java 9.99% 9.98% -0.01%
    ExperimentPayloadProto.java 5.13% 5.12% -0.01%
    FetchEligibleCampaignsRequest.java 32.61% 32.97% +0.36%
    FetchEligibleCampaignsResponse.java 43.22% 42.86% -0.36%
    MessagesProto.java 36.21% 36.13% -0.08%

  • firebase-messaging

    SDK overall coverage changed from ? (13b12ca) to 83.56% (dfde5f86) by ?.

    Click to show coverage changes in 23 files.
    Filename Base (13b12ca) Head (dfde5f86) Diff
    CommonNotificationBuilder.java ? 91.63% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 80.00% ?
    ExecutorFactory.java ? 0.00% ?
    FcmExecutors.java ? 85.71% ?
    FirebaseMessaging.java ? 65.00% ?
    FirebaseMessagingRegistrar.java ? 83.33% ?
    FirebaseMessagingService.java ? 94.79% ?
    FirelogAnalyticsEvent.java ? 26.67% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 63.93% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    RemoteMessage.java ? 95.48% ?
    RemoteMessageCreator.java ? 88.89% ?
    SendException.java ? 100.00% ?
    SharedPreferencesQueue.java ? 98.44% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 91.38% ?
    TopicsSyncTask.java ? 53.33% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (dfde5f86) is created by Prow via merging commits: 13b12ca 7e4873e.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (13b12ca) Head (dfde5f86) Diff
    aar 998 kB 998 kB +441 B (+0.0%)
    apk (aggressive) 413 kB 415 kB +2.26 kB (+0.5%)
    apk (release) 3.14 MB 3.15 MB +2.22 kB (+0.1%)

  • firebase-firestore-ktx

    Type Base (13b12ca) Head (dfde5f86) Diff
    apk (aggressive) 429 kB 431 kB +2.26 kB (+0.5%)
    apk (release) 3.62 MB 3.63 MB +2.08 kB (+0.1%)

  • firebase-inappmessaging

    Type Base (13b12ca) Head (dfde5f86) Diff
    aar 493 kB 494 kB +288 B (+0.1%)
    apk (aggressive) 615 kB 617 kB +2.37 kB (+0.4%)
    apk (release) 3.30 MB 3.30 MB +1.86 kB (+0.1%)

  • firebase-inappmessaging-display

    Type Base (13b12ca) Head (dfde5f86) Diff
    apk (aggressive) 1.42 MB 1.43 MB +2.44 kB (+0.2%)
    apk (release) 4.54 MB 4.54 MB +2.06 kB (+0.0%)

  • firebase-inappmessaging-display-ktx

    Type Base (13b12ca) Head (dfde5f86) Diff
    apk (aggressive) 1.44 MB 1.44 MB +2.39 kB (+0.2%)
    apk (release) 5.02 MB 5.03 MB +2.38 kB (+0.0%)

  • firebase-inappmessaging-ktx

    Type Base (13b12ca) Head (dfde5f86) Diff
    apk (aggressive) 630 kB 633 kB +2.40 kB (+0.4%)
    apk (release) 3.78 MB 3.79 MB +2.06 kB (+0.1%)

  • protolite-well-known-types

    Type Base (13b12ca) Head (dfde5f86) Diff
    aar 998 kB 1.00 MB +2.05 kB (+0.2%)
    apk (aggressive) 132 kB 134 kB +2.26 kB (+1.7%)
    apk (release) 659 kB 661 kB +2.26 kB (+0.3%)

Test Logs

Notes

Head commit (dfde5f86) is created by Prow via merging commits: 13b12ca 7e4873e.

@google-oss-bot
Copy link
Contributor

@rlazo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 7e4873e link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo rlazo requested a review from vkryachko November 27, 2020 20:50
@rlazo rlazo marked this pull request as ready for review November 27, 2020 20:50
@vkryachko
Copy link
Member

I wonder if the smoke tests failure is legit?

@rlazo
Copy link
Collaborator Author

rlazo commented Nov 27, 2020

I wonder if the smoke tests failure is legit?

They are all failures in firebase-perf, and in every case it's because the perf artifact was compiled depending on 3.11. They are expected.

@rlazo rlazo merged commit 0fa174c into master Nov 30, 2020
@rlazo rlazo deleted the rl.upprof branch November 30, 2020 14:22
@firebase firebase locked and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rlazo @google-oss-bot @vkryachko @googlebot