Skip to content

Enabling Test Orchestrator #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Conversation

ramanpreetSinghKhinda
Copy link
Contributor

@ramanpreetSinghKhinda ramanpreetSinghKhinda commented Dec 2, 2020

b/174660554

Enabling Test Orchestrator to run each of app's instrumentation tests independently without accumulating shared states.

References:

Enabling Test Orchestrator to run each of app's instrumentation tests independently without accumulating shared states.

References:
  - https://firebase.google.com/docs/test-lab/android/firebase-console#new_instrumentation_tests_with_orchestrator
 - http://cloud/sdk/gcloud/reference/firebase/test/android/run#--use-orchestrator
@google-cla google-cla bot added the cla: yes Override cla label Dec 2, 2020
@vkryachko
Copy link
Member

@ramanpreetSinghKhinda while you're at it, do you mind also increasing the timeout to 45m? This should help with your e2e test failures we are seeing.
for reference: https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run#--timeout

@ramanpreetSinghKhinda
Copy link
Contributor Author

@ramanpreetSinghKhinda while you're at it, do you mind also increasing the timeout to 45m? This should help with your e2e test failures we are seeing.
for reference: https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run#--timeout

I think the current timeout is 15 min. Our tests usually finish within 9 min and the timeout in b/174660554 is not actually because our test is taking longer. It's because the android test runner is just waiting and not starting the test. If we increase the timeout it will just hold and waste resources for that timeout period.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.30% (00e6a8d) to 50.28% (47496a2c) by -0.02%.

    Filename Base (00e6a8d) Head (47496a2c) Diff
    DoubleNode.java 100.00% 88.24% -11.76%
  • firebase-messaging

    SDK overall coverage changed from 83.43% (00e6a8d) to 83.56% (47496a2c) by +0.14%.

    Filename Base (00e6a8d) Head (47496a2c) Diff
    TopicsSubscriber.java 89.66% 91.38% +1.72%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (47496a2c) is created by Prow via merging commits: 00e6a8d b8c98fa.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (00e6a8d) and head commit (47496a2c).

Test Logs

Notes

Head commit (47496a2c) is created by Prow via merging commits: 00e6a8d b8c98fa.

@ramanpreetSinghKhinda
Copy link
Contributor Author

I see past many runs of smoke tests are failing. Is this a known issue @yifanyang?

/test smoke-tests

@google-oss-bot
Copy link
Contributor

@ramanpreetSinghKhinda: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests b8c98fa link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramanpreetSinghKhinda ramanpreetSinghKhinda merged commit 837d136 into master Dec 3, 2020
@ramanpreetSinghKhinda ramanpreetSinghKhinda deleted the firebase-test-orchestrator branch December 3, 2020 01:37
@ramanpreetSinghKhinda
Copy link
Contributor Author

Per discussion with @yifanyang

It's safe to merge the PR. The smoke test has been failing since last weekend and Yifan is working on it.

@firebase firebase locked and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants