Skip to content

Add support for non-primitive Booleans. #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Conversation

vkryachko
Copy link
Member

No description provided.

@vkryachko vkryachko requested a review from rlazo December 7, 2020 22:06
@google-cla google-cla bot added the cla: yes Override cla label Dec 7, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (4b85eb8) and head commit (610f7811).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (610f7811) is created by Prow via merging commits: 4b85eb8 bb63cf7.

@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests bb63cf7 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-encoders-proto

    Type Base (4b85eb8) Head (610f7811) Diff
    apk (release) 21.1 kB 21.1 kB +48 B (+0.2%)

Test Logs

Notes

Head commit (610f7811) is created by Prow via merging commits: 4b85eb8 bb63cf7.

@vkryachko vkryachko merged commit e2535c9 into master Dec 8, 2020
@vkryachko vkryachko deleted the vk.proto_boolean branch December 8, 2020 02:40
@firebase firebase locked and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants