Skip to content

Grammar fixes for database comments. #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Grammar fixes for database comments. #2248

merged 1 commit into from
Dec 11, 2020

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Dec 11, 2020

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Dec 11, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (ad9f13b) and head commit (f6537261).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (f6537261) is created by Prow via merging commits: ad9f13b 2780687.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (ad9f13b) and head commit (f6537261).

Test Logs

Notes

Head commit (f6537261) is created by Prow via merging commits: ad9f13b 2780687.

@google-oss-bot
Copy link
Contributor

@rlazo: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 2780687 link /test check-changed
smoke-tests 2780687 link /test smoke-tests
device-check-changed 2780687 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schmidt-sebastian
Copy link
Contributor

cc @IanWyszynski

@rlazo rlazo merged commit 13b6736 into master Dec 11, 2020
@vkryachko
Copy link
Member

I think this PR broke master:

> Task :firebase-database:verifyGoogleJavaFormat FAILED

The following files are not formatted properly:

firebase-database/src/main/java/com/google/firebase/database/Query.java

Can this be fixed please?

cc @schmidt-sebastian

@schmidt-sebastian
Copy link
Contributor

Will send a fix by tomorrow.

@rlazo rlazo deleted the rl.dbgrfx branch January 6, 2021 18:09
@firebase firebase locked and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants