Background update #2254
Background update #2254
Conversation
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (5555c9a5) is created by Prow via merging commits: ee74cd0 5220062. |
|
The public api surface has changed for the subproject firebase-ml-modeldownloader: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (5555c9a5) is created by Prow via merging commits: ee74cd0 5220062. |
| // check for latest model and download newest | ||
| break; | ||
| // check for latest model, wait for download if newer model exists | ||
| return getCustomModelTask(modelName, conditions); |
There was a problem hiding this comment.
Should localModel.getModelHash() be passed here, to avoid triggering a download if there is no newer model?
There was a problem hiding this comment.
Good catch, fixed.
| } | ||
|
|
||
| // if modelHash matches current local model just return local model. | ||
| if (currentModel |
There was a problem hiding this comment.
in current flow no - but in theory it's a possibility - fixed and added a few more unit tests.
…al proto. This allows for proper json to proto conversion and in local tests messages now reach the spanner queue.
No description provided.