Added FirebaseMlException and Logging round 1. #2259
Conversation
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (ac542ad1) is created by Prow via merging commits: cdc8e88 f4d85e8. |
|
The public api surface has changed for the subproject firebase-ml-modeldownloader: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (ac542ad1) is created by Prow via merging commits: cdc8e88 f4d85e8. |
…al proto. This allows for proper json to proto conversion and in local tests messages now reach the spanner queue.
| generateProtoTasks { | ||
| all().each { task -> | ||
| task.builtins { | ||
| java { } |
There was a problem hiding this comment.
add option 'lite' (see firebase-firestore.gradle )
There was a problem hiding this comment.
If I add that then - JsonFormat.parser().merge fails (based on testLogRequest_jsontToProto) which doesn't use lite option. Can you suggest an alternative?
There was a problem hiding this comment.
Also note - the proto is only for testing and shouldn't affect the sdk sizing.
There was a problem hiding this comment.
Oh, right. JsonFormat parser actually requires the full runtime to work. Since it's used for tests, I think you can do the same crashlytics is doing https://github.com/firebase/firebase-android-sdk/blob/master/firebase-crashlytics/firebase-crashlytics.gradle#L88
just use testImplementation instead of androidTestImplementation
There was a problem hiding this comment.
removed all the androidTestImplementation - these were not used. The encoding was already there for the regular implementation level (and validated it is needed at that level)
There was a problem hiding this comment.
AFAIK you can just get rid of the whole generateProtoTasks sections.
There was a problem hiding this comment.
Appears required - gives error when removed:
Execution failed for task ':firebase-ml-modeldownloader:generateDebugUnitTestProto'.
protoc: stdout: . stderr: Missing output directives.
There was a problem hiding this comment.
Got it. Thanks for following through!
...der/src/main/java/com/google/firebase/ml/modeldownloader/internal/SharedPreferencesUtil.java
Show resolved
Hide resolved
|
/test smoke-tests |
* Added FirebaseMlException and Logging round 1. * Updating files per failed tests. * Fixing to single junit. * Updates FirebaseMlLogEvent ModelOption name to Options to make internal proto. This allows for proper json to proto conversion and in local tests messages now reach the spanner queue. * Add ability to get download id for file progress tracking. * removing androidTestImplementation - these are not used.
No description provided.