Skip to content

Port flaky test fix from web. #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2019
Merged

Port flaky test fix from web. #226

merged 1 commit into from
Feb 1, 2019

Conversation

mikelehen
Copy link
Contributor

@mikelehen mikelehen requested a review from gsoltis February 1, 2019 00:28
@googlebot googlebot added the cla: yes Override cla label Feb 1, 2019
@mikelehen
Copy link
Contributor Author

/retest

wilhuff
wilhuff approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikelehen mikelehen merged commit 9d62075 into master Feb 1, 2019
@mikelehen mikelehen deleted the mikelehen/port-flaky-test-fix branch February 1, 2019 17:17
@firebase firebase locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

@gsoltis gsoltis Awaiting requested review from gsoltis

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikelehen @wilhuff @gsoltis @googlebot @google-oss-bot