Skip to content

Set TrafficStats tag in FirebaseInstallationServiceClient.createFirebaseInstallation #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 11, 2021
Merged

Set TrafficStats tag in FirebaseInstallationServiceClient.createFirebaseInstallation #2270

merged 4 commits into from
Jan 11, 2021

Conversation

regisd
Copy link
Contributor

@regisd regisd commented Dec 17, 2020 •
edited
Loading

Fixes #2227

Tested:
I verified that com.google.googlequicksearchbox doesn't have the violation anymore in the e2e test.

Signed-off-by: Régis Décamps [email protected]

@regisd
Set TrafficStats tag in FirebaseInstallationServiceClient.createFireb…
1d9d0b6 
…aseInstallation

Fixes firebase#2227

Tested:
I verified that com.google.googlequicksearchbox doesn't have the violation anymore in the e2e test.

Signed-off-by: Régis Décamps <[email protected]>
@google-cla google-cla bot added the cla: yes Override cla label Dec 17, 2020
@google-oss-bot
Copy link
Contributor

Hi @regisd. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@regisd
Copy link
Contributor Author

regisd commented Dec 17, 2020

TrafficStats tags should be unique.

Does GMS have emulator tests? Is there a way to check against StrictMode violations?

@regisd
Copy link
Contributor Author

regisd commented Jan 11, 2021

I've added tagging on all url.openConnection() in firebase-installations.
PTAL (in conjunction with cl/351113253 and feel free to squash submit).

@ankitaj224
Copy link
Contributor

Thank you so much @regisd

@ankitaj224 ankitaj224 merged commit 3dee255 into firebase:master Jan 11, 2021
@regisd regisd deleted the trafficstats branch January 12, 2021 09:28
andreaowu pushed a commit that referenced this pull request Jan 29, 2021
@regisd @andreaowu
Set TrafficStats tag in FirebaseInstallationServiceClient.createFireb…
e48b842 
…aseInstallation (#2270)

* Set TrafficStats tag in FirebaseInstallationServiceClient.createFirebaseInstallation

Fixes #2227

Tested:
I verified that com.google.googlequicksearchbox doesn't have the violation anymore in the e2e test.

Signed-off-by: Régis Décamps <[email protected]>

* Add TrafficStats tags for Create isntallation, Delete installation and Generate Token.

* Rename tags to be prefixed with TRAFFIC_STATS

* Update copyright header for 2021.
@firebase firebase locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankitaj224 ankitaj224 ankitaj224 approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla needs-ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StrictMode UNTAGGED_SOCKET in FirebaseInstallationServiceClient
3 participants
@regisd @google-oss-bot @ankitaj224