Skip to content

Update FirebaseFunctions JavaDoc #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 6, 2021
Merged

Update FirebaseFunctions JavaDoc #2271

merged 4 commits into from
Jan 6, 2021

Conversation

samtstern
Copy link
Contributor

See http://cl/347916042 for context

@googlebot googlebot added the cla: yes Override cla label Dec 17, 2020
@samtstern samtstern requested a review from rlazo December 17, 2020 16:32
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 17, 2020 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (f779577) and head commit (dbd610ab).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (dbd610ab) is created by Prow via merging commits: f779577 9db65c9.

@rlazo
Copy link
Collaborator

rlazo commented Jan 6, 2021

/retest

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 6, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (f779577) and head commit (dbd610ab).

Test Logs

Notes

Head commit (dbd610ab) is created by Prow via merging commits: f779577 9db65c9.

samtstern and others added 2 commits January 6, 2021 11:02
@samtstern samtstern requested a review from rlazo January 6, 2021 11:02
@rlazo
Copy link
Collaborator

rlazo commented Jan 6, 2021

BTW the test is failing because of :firebase-functions:verifyGoogleJavaFormat. A ./gradlew firebase-functions:gJF should do the trick.

@google-oss-bot
Copy link
Contributor

@samtstern: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 9db65c9 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo
Copy link
Collaborator

rlazo commented Jan 6, 2021

It's safe to ignore the smoke-tests. The failure is because

com.google.firebase.FirebaseTooManyRequestsException: This project's quota for this operation has been exceeded. [

@samtstern samtstern merged commit 6ec79d3 into master Jan 6, 2021
schmidt-sebastian pushed a commit that referenced this pull request Jan 9, 2021
@samtstern @rlazo @schmidt-sebastian
Update FirebaseFunctions JavaDoc (#2271)
c63855b 
Co-authored-by: Rodrigo Lazo <[email protected]>
@firebase firebase locked and limited conversation to collaborators Feb 6, 2021
@rlazo rlazo deleted the ss-functions-javadoc branch September 7, 2022 03:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@Padil77 Padil77 Padil77 approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samtstern @google-oss-bot @rlazo @Padil77 @googlebot