Skip to content

Handle expired url file paths with retries. #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2021
Merged

Handle expired url file paths with retries. #2276

merged 1 commit into from
Jan 6, 2021

Conversation

annzimmer
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Dec 21, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-ml-modeldownloader

    SDK overall coverage changed from 88.57% (ec78ab8) to 87.93% (00b8ca51) by -0.64%.

    Filename Base (ec78ab8) Head (00b8ca51) Diff
    FirebaseModelDownloader.java 94.29% 89.42% -4.86%
    ModelFileDownloadService.java 90.65% 89.81% -0.84%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (00b8ca51) is created by Prow via merging commits: ec78ab8 40dd8e3.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-ml-modeldownloader

    Type Base (ec78ab8) Head (00b8ca51) Diff
    aar 37.2 kB 40.1 kB +2.91 kB (+7.8%)
    apk (release) 704 kB 705 kB +964 B (+0.1%)

Test Logs

Notes

Head commit (00b8ca51) is created by Prow via merging commits: ec78ab8 40dd8e3.

@annzimmer annzimmer marked this pull request as ready for review January 5, 2021 18:45
@annzimmer annzimmer requested review from rlazo and vkryachko January 5, 2021 18:46
@annzimmer annzimmer merged commit f779577 into master Jan 6, 2021
@annzimmer annzimmer deleted the urlExpiry branch January 6, 2021 14:55
schmidt-sebastian pushed a commit that referenced this pull request Jan 9, 2021
@annzimmer @schmidt-sebastian
Handle expired url file paths with retries. (#2276)
c858d4c
@firebase firebase locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees

@pavelgj pavelgj

@manjanac manjanac

Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@annzimmer @google-oss-bot @rlazo @pavelgj @googlebot @manjanac