Skip to content

Implement startAfter for RTDB queries #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jan 14, 2021
Merged

Implement startAfter for RTDB queries #2277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8a20103
startAfter temporary commit
jmwski Dec 17, 2020
b217ab7
Merge branch 'master' into jw/start-after
jmwski Dec 17, 2020
6022501
Merge branch 'master' into jw/start-after
jmwski Dec 21, 2020
e74719d
Add more tests
jmwski Dec 22, 2020
db3dc75
fix tests
jmwski Dec 22, 2020
93a9779
Move lex logic in PushIdGenerator, fix tests
jmwski Dec 22, 2020
52af0be
Fix push id generation scheme, add test to detect breakage
jmwski Jan 6, 2021
bd31fe4
test naming comments
jmwski Jan 6, 2021
0b75975
Fix start post bug
jmwski Jan 8, 2021
79157aa
Address review feedback
jmwski Jan 8, 2021
6b9bfb5
s/tryParseInt/tryParseLong/g
jmwski Jan 8, 2021
316b3ec
Handle startAfter(..., Integer.MAX_VALUE)
jmwski Jan 8, 2021
2ea31e0
Merge branch 'jw/start-after' of https://github.com/firebase/firebase…
jmwski Jan 8, 2021
3b5af05
Revert "s/tryParseInt/tryParseLong/g"
jmwski Jan 8, 2021
a96d7eb
more cleanup
jmwski Jan 8, 2021
9ab248d
Fix tests
jmwski Jan 8, 2021
4c43f39
test naming
jmwski Jan 8, 2021
3bffd8b
Return the proper value from successor
jmwski Jan 8, 2021
0ad2be2
Check key order boundary conditions
jmwski Jan 8, 2021
a0e6283
Add api.txt
jmwski Jan 11, 2021
889aa88
Add unit tests for successor
jmwski Jan 13, 2021
5ba8ff4
cleanup
jmwski Jan 13, 2021
6c017d5
Implement `endBefore` for RTDB queries (#2302)
jmwski Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firebase-database/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- [added] Added `Query.get()`, which allows users to receive a single data
snapshot. `Query.get()` returns the latest value even if an older value
already exists in cache.
- [added] Added `Query.startAfter()` filter for paginating RTDB queries.

# 19.5.1
- [fixed] Fixes a regression in v19.4 that may cause assertion failures,
Expand Down
14 changes: 13 additions & 1 deletion firebase-database/api.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ package com.google.firebase.database {

public class Query {
method @NonNull public com.google.firebase.database.ChildEventListener addChildEventListener(@NonNull com.google.firebase.database.ChildEventListener);
method @NonNull public com.google.android.gms.tasks.Task<com.google.firebase.database.DataSnapshot> get();
method public void addListenerForSingleValueEvent(@NonNull com.google.firebase.database.ValueEventListener);
method @NonNull public com.google.firebase.database.ValueEventListener addValueEventListener(@NonNull com.google.firebase.database.ValueEventListener);
method @NonNull public com.google.firebase.database.Query endAt(@Nullable String);
Expand All @@ -163,12 +162,19 @@ package com.google.firebase.database {
method @NonNull public com.google.firebase.database.Query endAt(@Nullable String, @Nullable String);
method @NonNull public com.google.firebase.database.Query endAt(double, @Nullable String);
method @NonNull public com.google.firebase.database.Query endAt(boolean, @Nullable String);
method @NonNull public com.google.firebase.database.Query endBefore(@Nullable String);
method @NonNull public com.google.firebase.database.Query endBefore(double);
method @NonNull public com.google.firebase.database.Query endBefore(boolean);
method @NonNull public com.google.firebase.database.Query endBefore(@Nullable String, @Nullable String);
method @NonNull public com.google.firebase.database.Query endBefore(double, @Nullable String);
method @NonNull public com.google.firebase.database.Query endBefore(boolean, @Nullable String);
method @NonNull public com.google.firebase.database.Query equalTo(@Nullable String);
method @NonNull public com.google.firebase.database.Query equalTo(double);
method @NonNull public com.google.firebase.database.Query equalTo(boolean);
method @NonNull public com.google.firebase.database.Query equalTo(@Nullable String, @Nullable String);
method @NonNull public com.google.firebase.database.Query equalTo(double, @Nullable String);
method @NonNull public com.google.firebase.database.Query equalTo(boolean, @Nullable String);
method @NonNull public com.google.android.gms.tasks.Task<com.google.firebase.database.DataSnapshot> get();
method @NonNull public com.google.firebase.database.DatabaseReference getRef();
method public void keepSynced(boolean);
method @NonNull public com.google.firebase.database.Query limitToFirst(int);
Expand All @@ -179,6 +185,12 @@ package com.google.firebase.database {
method @NonNull public com.google.firebase.database.Query orderByValue();
method public void removeEventListener(@NonNull com.google.firebase.database.ValueEventListener);
method public void removeEventListener(@NonNull com.google.firebase.database.ChildEventListener);
method @NonNull public com.google.firebase.database.Query startAfter(@Nullable String);
method @NonNull public com.google.firebase.database.Query startAfter(double);
method @NonNull public com.google.firebase.database.Query startAfter(boolean);
method @NonNull public com.google.firebase.database.Query startAfter(@Nullable String, @Nullable String);
method @NonNull public com.google.firebase.database.Query startAfter(double, @Nullable String);
method @NonNull public com.google.firebase.database.Query startAfter(boolean, @Nullable String);
method @NonNull public com.google.firebase.database.Query startAt(@Nullable String);
method @NonNull public com.google.firebase.database.Query startAt(double);
method @NonNull public com.google.firebase.database.Query startAt(boolean);
Expand Down
Loading