Skip to content

Restore fireperf smoke tests as #2158 is fixed. #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2021
Merged

Restore fireperf smoke tests as #2158 is fixed. #2282

merged 2 commits into from
Jan 13, 2021

Conversation

yifanyang
Copy link
Contributor

@google-cla google-cla bot added the cla: yes Override cla label Dec 23, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 23, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from ? (ec78ab8) to 50.36% (13d8a74e) by ?.

    Click to show coverage changes in 154 files.
    Filename Base (ec78ab8) Head (13d8a74e) Diff
    AckUserWrite.java ? 88.89% ?
    AndroidAuthTokenProvider.java ? 19.23% ?
    AndroidEventTarget.java ? 42.86% ?
    AndroidLogger.java ? 45.45% ?
    AndroidPlatform.java ? 39.02% ?
    AuthTokenProvider.java ? 0.00% ?
    BooleanNode.java ? 100.00% ?
    CacheNode.java ? 100.00% ?
    CachePolicy.java ? 50.00% ?
    CancelEvent.java ? 0.00% ?
    Change.java ? 91.67% ?
    ChildChangeAccumulator.java ? 96.67% ?
    ChildEventListener.java ? 0.00% ?
    ChildEventRegistration.java ? 0.00% ?
    ChildKey.java ? 90.00% ?
    ChildrenNode.java ? 73.40% ?
    Clock.java ? 0.00% ?
    CompoundHash.java ? 0.00% ?
    CompoundWrite.java ? 87.85% ?
    Connection.java ? 27.59% ?
    ConnectionAuthTokenProvider.java ? 0.00% ?
    ConnectionContext.java ? 88.89% ?
    ConnectionUtils.java ? 7.14% ?
    Constants.java ? 0.00% ?
    Context.java ? 75.93% ?
    CustomClassMapper.java ? 88.33% ?
    DataEvent.java ? 70.00% ?
    DataSnapshot.java ? 54.05% ?
    DatabaseConfig.java ? 63.04% ?
    DatabaseError.java ? 0.00% ?
    DatabaseException.java ? 50.00% ?
    DatabaseReference.java ? 23.36% ?
    DatabaseRegistrar.java ? 100.00% ?
    DefaultClock.java ? 100.00% ?
    DefaultLogger.java ? 66.67% ?
    DefaultPersistenceManager.java ? 75.73% ?
    DefaultRunLoop.java ? 57.14% ?
    DeferredValueNode.java ? 0.00% ?
    DoubleNode.java ? 88.24% ?
    EmptyNode.java ? 83.33% ?
    Event.java ? 100.00% ?
    EventGenerator.java ? 100.00% ?
    EventRaiser.java ? 25.00% ?
    EventRegistration.java ? 41.18% ?
    EventRegistrationZombieListener.java ? 0.00% ?
    EventTarget.java ? 0.00% ?
    Exclude.java ? 0.00% ?
    FirebaseDatabase.java ? 29.76% ?
    FirebaseDatabaseComponent.java ? 94.12% ?
    GAuthToken.java ? 81.82% ?
    GenericTypeIndicator.java ? 100.00% ?
    HostInfo.java ? 85.71% ?
    IgnoreExtraProperties.java ? 0.00% ?
    ImmutableTree.java ? 84.52% ?
    Index.java ? 53.33% ?
    IndexedFilter.java ? 93.62% ?
    IndexedNode.java ? 95.71% ?
    InternalHelpers.java ? 60.00% ?
    JsonMapper.java ? 59.32% ?
    KeyIndex.java ? 81.82% ?
    LRUCachePolicy.java ? 0.00% ?
    LeafNode.java ? 91.55% ?
    LimitedFilter.java ? 97.67% ?
    ListenComplete.java ? 0.00% ?
    ListenHashProvider.java ? 0.00% ?
    LogWrapper.java ? 71.43% ?
    Logger.java ? 100.00% ?
    LongNode.java ? 93.75% ?
    Merge.java ? 81.25% ?
    MessageBuilderFactory.java ? 0.00% ?
    MutableData.java ? 72.00% ?
    NameAndPriority.java ? 0.00% ?
    NamedNode.java ? 66.67% ?
    Node.java ? 50.00% ?
    NodeAndPath.java ? 0.00% ?
    NodeFilter.java ? 0.00% ?
    NodeSizeEstimator.java ? 0.00% ?
    NodeUtilities.java ? 74.14% ?
    NoopPersistenceManager.java ? 77.50% ?
    NotNull.java ? 0.00% ?
    Nullable.java ? 0.00% ?
    OffsetClock.java ? 75.00% ?
    OnDisconnect.java ? 0.00% ?
    Operation.java ? 100.00% ?
    OperationSource.java ? 94.12% ?
    Overwrite.java ? 80.00% ?
    Pair.java ? 30.00% ?
    ParsedUrl.java ? 66.67% ?
    Path.java ? 87.12% ?
    PathAndId.java ? 0.00% ?
    PathIndex.java ? 92.31% ?
    PersistenceManager.java ? 0.00% ?
    PersistenceStorageEngine.java ? 0.00% ?
    PersistentConnection.java ? 0.00% ?
    PersistentConnectionImpl.java ? 16.34% ?
    Platform.java ? 0.00% ?
    Predicate.java ? 100.00% ?
    PriorityIndex.java ? 83.33% ?
    PriorityUtilities.java ? 76.92% ?
    PropertyName.java ? 0.00% ?
    PruneForest.java ? 76.06% ?
    PushIdGenerator.java ? 70.37% ?
    Query.java ? 49.70% ?
    QueryParams.java ? 89.76% ?
    QuerySpec.java ? 88.46% ?
    RangeMerge.java ? 0.00% ?
    RangedFilter.java ? 100.00% ?
    Repo.java ? 10.34% ?
    RepoInfo.java ? 71.88% ?
    RepoManager.java ? 35.82% ?
    RequestResultCallback.java ? 0.00% ?
    RetryHelper.java ? 74.19% ?
    RunLoop.java ? 0.00% ?
    ServerValue.java ? 0.00% ?
    ServerValues.java ? 50.00% ?
    SnapshotHolder.java ? 100.00% ?
    SparseSnapshotTree.java ? 17.86% ?
    SqlPersistenceStorageEngine.java ? 0.00% ?
    StringListReader.java ? 0.00% ?
    StringNode.java ? 87.50% ?
    SyncPoint.java ? 88.12% ?
    SyncTree.java ? 62.99% ?
    Tag.java ? 71.43% ?
    ThreadBackgroundExecutor.java ? 0.00% ?
    ThreadInitializer.java ? 100.00% ?
    ThreadPoolEventTarget.java ? 0.00% ?
    ThrowOnExtraProperties.java ? 0.00% ?
    TrackedQuery.java ? 46.15% ?
    TrackedQueryManager.java ? 99.45% ?
    Transaction.java ? 0.00% ?
    Tree.java ? 50.00% ?
    TreeNode.java ? 25.00% ?
    UserWriteRecord.java ? 57.14% ?
    Utilities.java ? 68.99% ?
    Validation.java ? 41.67% ?
    ValidationPath.java ? 86.96% ?
    ValueEventListener.java ? 0.00% ?
    ValueEventRegistration.java ? 0.00% ?
    ValueIndex.java ? 0.00% ?
    ValueProvider.java ? 50.00% ?
    View.java ? 85.11% ?
    ViewCache.java ? 100.00% ?
    ViewProcessor.java ? 92.10% ?
    WebSocket.java ? 34.50% ?
    WebSocketEventHandler.java ? 0.00% ?
    WebSocketException.java ? 50.00% ?
    WebSocketHandshake.java ? 26.67% ?
    WebSocketMessage.java ? 0.00% ?
    WebSocketReceiver.java ? 12.82% ?
    WebSocketWriter.java ? 19.23% ?
    WebsocketConnection.java ? 32.39% ?
    WriteTree.java ? 76.67% ?
    WriteTreeRef.java ? 100.00% ?
    ZombieEventManager.java ? 0.00% ?

  • firebase-firestore

    SDK overall coverage changed from 46.83% (ec78ab8) to 46.78% (13d8a74e) by -0.05%.

    Filename Base (ec78ab8) Head (13d8a74e) Diff
    GrpcCallProvider.java 68.18% 57.95% -10.23%

  • firebase-messaging

    SDK overall coverage changed from ? (ec78ab8) to 83.43% (13d8a74e) by ?.

    Click to show coverage changes in 23 files.
    Filename Base (ec78ab8) Head (13d8a74e) Diff
    CommonNotificationBuilder.java ? 91.63% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 80.00% ?
    ExecutorFactory.java ? 0.00% ?
    FcmExecutors.java ? 85.71% ?
    FirebaseMessaging.java ? 65.00% ?
    FirebaseMessagingRegistrar.java ? 83.33% ?
    FirebaseMessagingService.java ? 94.79% ?
    FirelogAnalyticsEvent.java ? 26.67% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 63.93% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    RemoteMessage.java ? 95.48% ?
    RemoteMessageCreator.java ? 88.89% ?
    SendException.java ? 100.00% ?
    SharedPreferencesQueue.java ? 98.44% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 89.66% ?
    TopicsSyncTask.java ? 53.33% ?

  • firebase-storage

    SDK overall coverage changed from 85.75% (ec78ab8) to 85.52% (13d8a74e) by -0.22%.

    Filename Base (ec78ab8) Head (13d8a74e) Diff
    StorageTask.java 84.59% 84.29% -0.30%
    UploadTask.java 81.68% 80.22% -1.47%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (13d8a74e) is created by Prow via merging commits: ec78ab8 ef71545.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 23, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (ec78ab8) and head commit (13d8a74e).

Test Logs

Notes

Head commit (13d8a74e) is created by Prow via merging commits: ec78ab8 ef71545.

@yifanyang
Copy link
Contributor Author

/retest

sunmou99
sunmou99 approved these changes Dec 23, 2020
View reviewed changes
Copy link
Collaborator

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed ef71545 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yifanyang yifanyang requested a review from vkryachko January 5, 2021 21:33
@yifanyang yifanyang merged commit 1faa4e2 into master Jan 13, 2021
@yifanyang yifanyang deleted the yifany/smoke-test branch January 13, 2021 18:48
andreaowu pushed a commit that referenced this pull request Jan 29, 2021
@yifanyang @andreaowu
Restore fireperf smoke tests as #2158 is fixed. (#2282)
0508c36 
* Restore fireperf smoke tests as #2158 is fixed.

#2158
@firebase firebase locked and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@sunmou99 sunmou99 sunmou99 approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yifanyang @google-oss-bot @vkryachko @sunmou99