Implement endBefore for RTDB queries
#2302
Conversation
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (5a7ebb2c) is created by Prow via merging commits: 5ba8ff4 018e32d. |
|
The public api surface has changed for the subproject firebase-database: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (5a7ebb2c) is created by Prow via merging commits: 5ba8ff4 018e32d. |
|
The public api surface has changed for the subproject firebase-database: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-database: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-database: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-database: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-database: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-database: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
@schmidt-sebastian Ready for review. |
|
@schmidt-sebastian Do you have any thoughts on whether we should merge this PR into #2277 and then merge the two to master? |
| public void testPredecessorSpecialValue() { | ||
| assertEquals( | ||
| PushIdGenerator.predecessor(String.valueOf(MIN_PUSH_CHAR)), | ||
| String.valueOf(Integer.MAX_VALUE)); |
There was a problem hiding this comment.
Same comment as in other PR: These arguments should be flipped.
| @@ -478,6 +478,96 @@ private Query startAt(Node node, String key) { | |||
| return new Query(repo, path, newParams, orderByCalled); | |||
| } | |||
|
|
|||
| /** | |||
| * Create a query constrained to only return child nodes with a value greater than the given | |||
| * value, using the given orderBy directive or priority as default. | |||
There was a problem hiding this comment.
I just realized that all these comments say "value greater than", when it should be "value less than".
| * value, using the given orderBy directive or priority as default, and additionally only child | ||
| * nodes with a key greater than or equal to the given key. | ||
| * | ||
| * @param value The priority to start at |
There was a problem hiding this comment.
s/value/priority
| * value, using the given orderBy directive or priority as default, and additionally only child | ||
| * nodes with a key greater than or equal to the given key. | ||
| * | ||
| * @param value The priority to start at |
There was a problem hiding this comment.
s/value/priority
| * value, using the given orderBy directive or priority as default, and additionally only child | ||
| * nodes with a key greater than or equal to the given key. | ||
| * | ||
| * @param value The priority to start at |
There was a problem hiding this comment.
s/value/priority
|
@IanWyszynski: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
go/rtdb-exclusive-query-filters