Clear cache #2313
Clear cache #2313
Conversation
Removes old download attempts from the download managers and resets the models in shared preferences.
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (fdfcac43) is created by Prow via merging commits: 3dee255 3176326. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (fdfcac43) is created by Prow via merging commits: 3dee255 3176326. |
|
The public api surface has changed for the subproject firebase-ml-modeldownloader: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
| // start download in back ground, return local model | ||
| getCustomModelTask(modelName, conditions, localModel.getModelHash()); | ||
| return Tasks.forResult(localModel); | ||
| // start upload in background, if newer model exists |
There was a problem hiding this comment.
no download - I fixed this in a bunch of places, where I was using it incorrectly. Thanks for noticing.
|
@annzimmer: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Clean up/remove failed or completed download attempts. Removes old download attempts from the download managers and resets the models in shared preferences. * fix guarded by issues * minor updates * Code to handle weird states caused by cache clearing. * fix merge error * remove thrown exception - pass back as task exception. * remove thrown exception - pass back as task exception. * fixing incorrect upload word usage.
No description provided.