Skip to content

Fix encoding issue in error stream. #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2021
Merged

Fix encoding issue in error stream. #2317

merged 1 commit into from
Jan 13, 2021

Conversation

annzimmer
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes Override cla label Jan 12, 2021
@google-oss-bot
Copy link
Contributor

@annzimmer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
copyright-check cf9d714 link /test copyright-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-ml-modeldownloader

    SDK overall coverage changed from 84.25% (8fcd37c) to 84.36% (983a5abe) by +0.10%.

    Filename Base (8fcd37c) Head (983a5abe) Diff
    CustomModelDownloadService.java 85.58% 86.79% +1.22%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (983a5abe) is created by Prow via merging commits: 8fcd37c cf9d714.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-ml-modeldownloader

    Type Base (8fcd37c) Head (983a5abe) Diff
    aar 81.9 kB 82.0 kB +22 B (+0.0%)
    apk (release) 786 kB 786 kB +88 B (+0.0%)

Test Logs

Notes

Head commit (983a5abe) is created by Prow via merging commits: 8fcd37c cf9d714.

@annzimmer annzimmer marked this pull request as ready for review January 13, 2021 00:02
@annzimmer annzimmer requested review from rlazo and vkryachko January 13, 2021 00:02
@annzimmer annzimmer merged commit cb79c79 into master Jan 13, 2021
@annzimmer annzimmer deleted the errorStream branch January 13, 2021 16:50
andreaowu pushed a commit that referenced this pull request Jan 29, 2021
@annzimmer @andreaowu
Fix encoding issue in error stream. (#2317)
7cf2b3e
@firebase firebase locked and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees

@pavelgj pavelgj

@manjanac manjanac

@annzimmer annzimmer

Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@annzimmer @google-oss-bot @rlazo @pavelgj @manjanac