Key comparison for RTDB queries should correctly handle boundary sentinels

[jmwski]

In order for startAfter and endBefore to have the correct ordering semantics, we need to return the objects MAX_KEY and MIN_KEY. Otherwise, the comparison function won't work properly in all cases:

https://github.com/firebase/firebase-android-sdk/blob/master/firebase-database/src/main/java/com/google/firebase/database/snapshot/ChildKey.java#L74-L76

[google-oss-bot]

Coverage Report

Affected SDKs

• firebase-database

  SDK overall coverage changed from 50.42% (998b18a) to 50.41% (aedfc809) by -0.01%.

  Filename	Base (998b18a)	Head (aedfc809)	Diff
  SyncTree.java	62.99%	62.50%	-0.49%
  ViewProcessor.java	91.79%	92.10%	+0.30%

Test Logs

• Base (998b18ae): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1350088842018820096
• Head (aedfc809): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/2328/check-coverage-changed/1350091610586615814

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (aedfc809) is created by Prow via merging commits: 998b18a 6f741f3.

[google-oss-bot]

Binary Size Report

Affected SDKs

• firebase-database

  Type	Base (998b18a)	Head (aedfc809)	Diff
  aar	492 kB	492 kB	+8 B (+0.0%)
  apk (release)	1.09 MB	1.09 MB	-60 B (-0.0%)

Test Logs

• Base (998b18ae): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-binary-size/1350088842014625792
• Head (aedfc809): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/2328/binary-size/1350091610586615815

Notes

Head commit (aedfc809) is created by Prow via merging commits: 998b18a 6f741f3.

[schmidt-sebastian]

Hm. Should we update the comparison function instead? This bug can show up in a number of places.

[google-oss-bot]

@IanWyszynski: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
device-check-changed	6f741f3	link	/test device-check-changed
smoke-tests	6f741f3	link	/test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.