Add ByteBufferInputStream #2329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow all three overloads for loadBundle() to use the same decoding logic. See #2322 for how this all comes together.
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (4a902f9d) is created by Prow via merging commits: 998b18a 02799ca. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (4a902f9d) is created by Prow via merging commits: 998b18a 02799ca. |
wu-hui
approved these changes
Jan 20, 2021
| if (!buffer.hasRemaining()) { | ||
| return -1; | ||
| } | ||
| return buffer.get() & 0xFF; |
There was a problem hiding this comment.
Add a comment here to explain why & 0xFF?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow all three overloads for loadBundle() to use the same decoding logic.
See #2322 for how this all comes together.