Skip to content

Add bundle package #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 19, 2021
Merged

Add bundle package #2332

merged 4 commits into from
Jan 19, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@schmidt-sebastian
Add bundle package
52e0691 
This moves the Bundle files to the their own package and deletes the duplicate Bundle class (the same class exists as BundleMetadata, but was merged incorrecly).

BundleCache stays in local along with the other persistence classes.
@google-cla google-cla bot added the cla: yes Override cla label Jan 15, 2021
@schmidt-sebastian schmidt-sebastian changed the base branch from master to mrschmidt/bundle/master January 15, 2021 18:14
@schmidt-sebastian schmidt-sebastian changed the title Mrschmidt/bundle/move Add bundle package Jan 15, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 15, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 47.86% (90d4c35) to 47.95% (d3a344bb) by +0.09%.

    Filename Base (90d4c35) Head (d3a344bb) Diff
    GrpcCallProvider.java 57.95% 68.18% +10.23%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (d3a344bb) is created by Prow via merging commits: 90d4c35 f96ed35.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added package com.google.firebase.firestore.bundle [AddedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added package com.google.firebase.firestore.bundle [AddedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (90d4c35) Head (d3a344bb) Diff
    aar 1.06 MB 1.06 MB -478 B (-0.0%)
    apk (release) 3.16 MB 3.16 MB +768 B (+0.0%)

Test Logs

Notes

Head commit (d3a344bb) is created by Prow via merging commits: 90d4c35 f96ed35.

@firebase firebase deleted a comment from google-oss-bot Jan 18, 2021
@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Jan 19, 2021
@schmidt-sebastian schmidt-sebastian merged commit 01a8945 into mrschmidt/bundle/master Jan 19, 2021
@wu-hui wu-hui mentioned this pull request Jan 20, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Feb 19, 2021
@kaibolay kaibolay deleted the mrschmidt/bundle/move branch September 15, 2022 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui