Mark Dependency.optional as deprecated. #2334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlazo
reviewed
Jan 18, 2021
firebase-components/src/main/java/com/google/firebase/components/Dependency.java
Outdated
Show resolved
Hide resolved
firebase-components/src/main/java/com/google/firebase/components/Dependency.java
Outdated
Show resolved
Hide resolved
| * | ||
| * <p>Optional dependencies can be missing at runtime(being {@code null}) and dependents must be | ||
| * ready to handle that. | ||
| */ |
There was a problem hiding this comment.
Nope, this is now the recommended optional dependency, see the deprecation message in Dependency.optional().
Co-authored-by: Rodrigo Lazo <[email protected]>
rlazo
approved these changes
Jan 18, 2021
Coverage ReportAffected SDKsNo changes between base commit (6ccc9de) and head commit (1fda5204). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (1fda5204) is created by Prow via merging commits: 6ccc9de b8ea0b3. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (1fda5204) is created by Prow via merging commits: 6ccc9de b8ea0b3. |
|
/test check-changed |
schmidt-sebastian
pushed a commit
that referenced
this pull request
Jan 19, 2021
* Mark Dependency.optional as deprecated. * Apply suggestions from code review Co-authored-by: Rodrigo Lazo <[email protected]> Co-authored-by: Rodrigo Lazo <[email protected]>
andreaowu
pushed a commit
that referenced
this pull request
Jan 29, 2021
* Mark Dependency.optional as deprecated. * Apply suggestions from code review Co-authored-by: Rodrigo Lazo <[email protected]> Co-authored-by: Rodrigo Lazo <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.