Ml logging

[annzimmer]

No description provided.

[google-oss-bot]

Coverage Report

Affected SDKs

• firebase-ml-modeldownloader

  SDK overall coverage changed from 85.08% (843b963) to 84.55% (975d26f0) by -0.53%.

  Filename	Base (843b963)	Head (975d26f0)	Diff
  CustomModelDownloadService.java	89.66%	86.03%	-3.63%
  FirebaseMlException.java	57.14%	100.00%	+42.86%
  FirebaseMlLogEvent.java	97.47%	97.65%	+0.18%
  FirebaseMlLogger.java	88.42%	88.89%	+0.47%
  FirebaseModelDownloader.java	88.51%	84.38%	-4.14%
  FirebaseModelDownloaderRegistrar.java	91.67%	94.87%	+3.21%
  ModelFileDownloadService.java	91.70%	90.76%	-0.95%

Test Logs

• Base (843b9636): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1352689096815808512
• Head (975d26f0): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/2355/check-coverage-changed/1354467327688577031

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (975d26f0) is created by Prow via merging commits: 843b963 e12615d.

[google-oss-bot]

The public api surface has changed for the subproject firebase-ml-modeldownloader:
error: Added field com.google.firebase.ml.modeldownloader.FirebaseMlException.DOWNLOAD_URL_EXPIRED [AddedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

[google-oss-bot]

Binary Size Report

Affected SDKs

• firebase-ml-modeldownloader

  Type	Base (843b963)	Head (975d26f0)	Diff
  aar	84.4 kB	85.9 kB	+1.56 kB (+1.9%)
  apk (aggressive)	128 kB	128 kB	+160 B (+0.1%)
  apk (release)	786 kB	787 kB	+924 B (+0.1%)

Test Logs

• Base (843b9636): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-binary-size/1352689096815808515
• Head (975d26f0): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/2355/binary-size/1354467327688577029

Notes

Head commit (975d26f0) is created by Prow via merging commits: 843b963 e12615d.

[google-oss-bot]

The public api surface has changed for the subproject firebase-ml-modeldownloader:
error: Method com.google.firebase.ml.modeldownloader.CustomModel.getFile no longer throws exception com.google.firebase.ml.modeldownloader.FirebaseMlException [ChangedThrows]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

[rlazo]

Looks like you're also removing transport from the deps. Is it no longer needed?

[google-oss-bot]

The public api surface has changed for the subproject firebase-ml-modeldownloader:
error: Added field com.google.firebase.ml.modeldownloader.FirebaseMlException.MODEL_HASH_MISMATCH [AddedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

[annzimmer]

I moved the transport dep to the FirebaseMlLogger - that way I won't have to pass it into every class - just have each class that needed logging get an instance of the FirebaseMlLogger. Hoping that was appropriate.

[rlazo]

I moved the transport dep to the FirebaseMlLogger - that way I won't have to pass it into every class - just have each class that needed logging get an instance of the FirebaseMlLogger. Hoping that was appropriate.

Yes, definitely. Just checking 👍

[annzimmer]

/retest