Skip to content

Fixes a bug in transport context selection. #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Conversation

vkryachko
Copy link
Member

b/177990711

@google-cla google-cla bot added the cla: yes Override cla label Jan 25, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • transport-runtime

    SDK overall coverage changed from 58.71% (843b963) to 58.74% (751ac672) by +0.03%.

    Filename Base (843b963) Head (751ac672) Diff
    SQLiteEventStore.java 51.09% 51.27% +0.18%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (751ac672) is created by Prow via merging commits: 843b963 9d12e84.

@vkryachko vkryachko requested a review from rlazo January 25, 2021 21:20
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • transport-runtime

    Type Base (843b963) Head (751ac672) Diff
    aar 164 kB 164 kB +35 B (+0.0%)
    apk (aggressive) 33.1 kB 33.1 kB +20 B (+0.1%)
    apk (release) 63.1 kB 63.1 kB +8 B (+0.0%)

Test Logs

Notes

Head commit (751ac672) is created by Prow via merging commits: 843b963 9d12e84.

@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 9d12e84 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko merged commit ba9abec into master Jan 28, 2021
@vkryachko vkryachko deleted the vk.transport_ctx_fix branch January 28, 2021 19:53
@firebase firebase locked and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants