Skip to content

Initial commit for the probuf compiler plugin. #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2021
Merged

Conversation

vkryachko
Copy link
Member

It consists of a fat jar can be used instead or in addition to standard
codegen.

The jar can be consumed via an absolute path to it(as is done in the
tests project) or as a maven artifact if available in one of the
configured repositories.

It consists of a fat jar can be used instead or in addition to standard
codegen.

The jar can be consumed via an absolute path to it(as is done in the
`tests` project) or as a maven artifact if available in one of the
configured repositories.
@googlebot googlebot added the cla: yes Override cla label Jan 27, 2021
@vkryachko vkryachko requested a review from rlazo January 27, 2021 16:49
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 27, 2021

Coverage Report

Affected SDKs

  • firebase-messaging

    SDK overall coverage changed from ? (0399724) to 83.70% (d1cf3b23) by ?.

    Click to show coverage changes in 23 files.
    Filename Base (0399724) Head (d1cf3b23) Diff
    CommonNotificationBuilder.java ? 91.63% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 80.00% ?
    ExecutorFactory.java ? 0.00% ?
    FcmExecutors.java ? 85.71% ?
    FirebaseMessaging.java ? 65.00% ?
    FirebaseMessagingRegistrar.java ? 83.33% ?
    FirebaseMessagingService.java ? 94.79% ?
    FirelogAnalyticsEvent.java ? 26.67% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 63.93% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    RemoteMessage.java ? 95.48% ?
    RemoteMessageCreator.java ? 88.89% ?
    SendException.java ? 100.00% ?
    SharedPreferencesQueue.java ? 98.44% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 93.10% ?
    TopicsSyncTask.java ? 53.33% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (d1cf3b23) is created by Prow via merging commits: 0399724 f406517.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 27, 2021

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (0399724) Head (d1cf3b23) Diff
    aar 1.04 MB 1.06 MB +21.1 kB (+2.0%)
    apk (aggressive) 416 kB 438 kB +22.0 kB (+5.3%)
    apk (release) 3.16 MB 3.18 MB +22.0 kB (+0.7%)
  • firebase-firestore-ktx

    Type Base (0399724) Head (d1cf3b23) Diff
    apk (aggressive) 431 kB 453 kB +22.0 kB (+5.1%)
    apk (release) 3.64 MB 3.66 MB +22.0 kB (+0.6%)
  • firebase-inappmessaging

    Type Base (0399724) Head (d1cf3b23) Diff
    aar 494 kB 506 kB +12.5 kB (+2.5%)
    apk (aggressive) 617 kB 631 kB +13.6 kB (+2.2%)
    apk (release) 3.31 MB 3.32 MB +13.6 kB (+0.4%)
  • firebase-inappmessaging-display

    Type Base (0399724) Head (d1cf3b23) Diff
    apk (aggressive) 1.43 MB 1.44 MB +13.6 kB (+0.9%)
    apk (release) 4.54 MB 4.55 MB +13.6 kB (+0.3%)
  • firebase-inappmessaging-display-ktx

    Type Base (0399724) Head (d1cf3b23) Diff
    apk (aggressive) 1.44 MB 1.46 MB +13.6 kB (+0.9%)
    apk (release) 5.03 MB 5.04 MB +13.6 kB (+0.3%)
  • firebase-inappmessaging-ktx

    Type Base (0399724) Head (d1cf3b23) Diff
    apk (aggressive) 633 kB 647 kB +13.6 kB (+2.1%)
    apk (release) 3.79 MB 3.80 MB +13.6 kB (+0.4%)
  • firebase-perf

    Type Base (0399724) Head (d1cf3b23) Diff
    aar 287 kB 292 kB +5.56 kB (+1.9%)
    apk (aggressive) 960 kB 966 kB +5.72 kB (+0.6%)
    apk (release) 2.42 MB 2.42 MB +5.71 kB (+0.2%)
  • firebase-perf-ktx

    Type Base (0399724) Head (d1cf3b23) Diff
    apk (aggressive) 976 kB 982 kB +5.71 kB (+0.6%)
    apk (release) 2.90 MB 2.90 MB +5.71 kB (+0.2%)

Test Logs

Notes

Head commit (d1cf3b23) is created by Prow via merging commits: 0399724 f406517.

@vkryachko
Copy link
Member Author

/retest

2 similar comments
@vkryachko
Copy link
Member Author

/retest

@vkryachko
Copy link
Member Author

/retest

@vkryachko vkryachko requested a review from rlazo January 28, 2021 15:17
@vkryachko vkryachko merged commit 5549559 into master Jan 28, 2021
@vkryachko vkryachko deleted the vk.protoc-gen branch January 28, 2021 19:52
@firebase firebase locked and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants