Skip to content

Clean up unused files and update README in Fireperf. #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

jeremyjiang-dev
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jan 27, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (d03a08e) and head commit (3de96d3d).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (3de96d3d) is created by Prow via merging commits: d03a08e b5a9b4b.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (d03a08e) and head commit (3de96d3d).

Test Logs

Notes

Head commit (3de96d3d) is created by Prow via merging commits: d03a08e b5a9b4b.

@ramanpreetSinghKhinda
Copy link
Contributor

@visumickey
Copy link
Contributor

@jeremyjiang-dev Where did these files from at the first place? Atleast the crash dump.

@jeremyjiang-dev
Copy link
Contributor Author

@jeremyjiang-dev Where did these files from at the first place? Atleast the crash dump.

Discussed offline. This file is generated accidentally on my machine and it is fine to remove it.

@jeremyjiang-dev
Copy link
Contributor Author

I think we need proguard file. Isn't it?

https://github.com/FirebasePrivate/firebase-android-release/blob/master/firebase-perf/proguard-rules.pro

The content in this file is all commented out. It is fine to remove it.

@jeremyjiang-dev jeremyjiang-dev merged commit 783c430 into master Jan 27, 2021
@jeremyjiang-dev jeremyjiang-dev deleted the perf-cleanup branch January 27, 2021 20:05
@firebase firebase locked and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants