Skip to content

Run fireperf e2e test from the public reepo. #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

yifanyang
Copy link
Contributor

Moving fireci plugin for fireperf end to end test from the release repo to the public repo.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.37% (d03a08e) to 50.42% (7955f556) by +0.04%.

    Filename Base (d03a08e) Head (7955f556) Diff
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%
  • firebase-messaging

    SDK overall coverage changed from 83.70% (d03a08e) to 83.43% (7955f556) by -0.28%.

    Filename Base (d03a08e) Head (7955f556) Diff
    TopicsSubscriber.java 93.10% 89.66% -3.45%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (7955f556) is created by Prow via merging commits: d03a08e fb4209a.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (d03a08e) and head commit (7955f556).

Test Logs

Notes

Head commit (7955f556) is created by Prow via merging commits: d03a08e fb4209a.

@yifanyang
Copy link
Contributor Author

/test check-changed

Copy link
Contributor

@jeremyjiang-dev jeremyjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next step will be removing the same file in the FirebasePrivate /firebase-android-release repo?

@visumickey
Copy link
Contributor

visumickey commented Jan 27, 2021

@yifanyang Thanks for making those changes. There are a couple of things I would like to learn a bit about:

  1. How can we learn about errors when running the test? Eg. if there are any changes to the SDK that is not compatible with the plugin, it would good to learn them.
  2. Where would we configure this script to run the E2E test app? Are there any other config changes required to enable this e2e test app run?

@yifanyang
Copy link
Contributor Author

The next step will be removing the same file in the FirebasePrivate /firebase-android-release repo?

Yes. It will be done in this PR. I'll submit them together.

@yifanyang
Copy link
Contributor Author

@yifanyang Thanks for making those changes. There are a couple of things I would like to learn a bit about:

  1. How can we learn about errors when running the test? Eg. if there are any changes to the SDK that is not compatible with the plugin, it would good to learn them.
  2. Where would we configure this script to run the E2E test app? Are there any other config changes required to enable this e2e test app run?

The status of recent runs for e2e test can be found here:

We have also set up an alert for these two jobs, which sends out emails in case of failures. @vkryachko Can you add fireperf team as a recipient of the alert?

This script is actually invoked/configured here (search fireperf-e2e-test in the file). The other config changes required for this migration is https://team-review.git.corp.google.com/c/firebase-android-core/test-infra/+/966612. I saw Raman has already added you as a reviewer though.

@yifanyang
Copy link
Contributor Author

/test check-changed

1 similar comment
@yifanyang
Copy link
Contributor Author

/test check-changed

@yifanyang yifanyang merged commit 2de6a3e into master Jan 27, 2021
@yifanyang yifanyang deleted the yifany/fireperf-e2e-test branch January 27, 2021 23:46
@firebase firebase locked and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants